Skip to content

Commit ed46f1f

Browse files
committed
platform: cznic: turris-omnia-mcu: fix Kconfig dependencies
The newly added driver causes a Kconfig warning: WARNING: unmet direct dependencies detected for RTC_CLASS Depends on [n]: !S390 [=y] Selected by [m]: - TURRIS_OMNIA_MCU [=m] && CZNIC_PLATFORMS [=y] && (MACH_ARMADA_38X || COMPILE_TEST [=y]) && I2C [=m] && OF [=y] && WATCHDOG [=y] The problem here is that it selects entire subsystems, which normal device drivers should not do. Changes all of these to 'depends on' instead. Fixes: dfa556e ("platform: cznic: turris-omnia-mcu: Add support for MCU connected GPIOs") Fixes: 90e700f ("platform: cznic: turris-omnia-mcu: Add support for poweroff and wakeup") Fixes: ab89fb5 ("platform: cznic: turris-omnia-mcu: Add support for MCU watchdog") Fixes: 41bb142 ("platform: cznic: turris-omnia-mcu: Add support for MCU provided TRNG") Reported-by: Nathan Chancellor <[email protected]> Signed-off-by: Arnd Bergmann <[email protected]>
1 parent 77dc111 commit ed46f1f

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/platform/cznic/Kconfig

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@ config TURRIS_OMNIA_MCU
1818
depends on I2C
1919
depends on OF
2020
depends on WATCHDOG
21-
select GPIOLIB
21+
depends on GPIOLIB
22+
depends on HW_RANDOM
23+
depends on RTC_CLASS
24+
depends on WATCHDOG_CORE
2225
select GPIOLIB_IRQCHIP
23-
select HW_RANDOM
24-
select RTC_CLASS
25-
select WATCHDOG_CORE
2626
help
2727
Say Y here to add support for the features implemented by the
2828
microcontroller on the CZ.NIC's Turris Omnia SOHO router.

0 commit comments

Comments
 (0)