Skip to content

Commit ed543f5

Browse files
Subbaraya Sundeepdavem330
authored andcommitted
octeontx2-pf: Unregister netdev at driver remove
Added unregister_netdev in the driver remove function. Generally unregister_netdev is called after disabling all the device interrupts but here it is called before disabling device mailbox interrupts. The reason behind this is VF needs mailbox interrupt to communicate with its PF to clean up its resources during otx2_stop. otx2_stop disables packet I/O and queue interrupts first and by using mailbox interrupt communicates to PF to free VF resources. Hence this patch calls unregister_device just before disabling mailbox interrupts. Fixes: 3184fb5 ("octeontx2-vf: Virtual function driver support") Signed-off-by: Subbaraya Sundeep <[email protected]> Signed-off-by: Sunil Goutham <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent c0376f4 commit ed543f5

File tree

1 file changed

+1
-0
lines changed
  • drivers/net/ethernet/marvell/octeontx2/nic

1 file changed

+1
-0
lines changed

drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -618,6 +618,7 @@ static void otx2vf_remove(struct pci_dev *pdev)
618618
vf = netdev_priv(netdev);
619619

620620
cancel_work_sync(&vf->reset_task);
621+
unregister_netdev(netdev);
621622
otx2vf_disable_mbox_intr(vf);
622623

623624
otx2_detach_resources(&vf->mbox);

0 commit comments

Comments
 (0)