Skip to content

Commit ed70aaa

Browse files
author
Bartosz Golaszewski
committed
Kconfig: reduce the amount of power sequencing noise
Kconfig will ask the user twice about power sequencing: once for the QCom WCN power sequencing driver and then again for the PCI power control driver using it. Let's automate the selection of PCI_PWRCTL by introducing a new hidden symbol: HAVE_PWRCTL which should be selected by all platforms that have the need to include PCI power control code (right now: only ARCH_QCOM). The pwrseq-based PCI pwrctl driver itself will then be selected by the drivers binding to devices that may require external handling of the power-up sequence (currently: ath11k and ath12k) based on the value of HAVE_PWRCTL. Make all PCI pwrctl Kconfig symbols hidden so that no questions are asked during configuration. Fixes: 4565d26 ("PCI/pwrctl: Add PCI power control core code") Reported-by: Linus Torvalds <[email protected]> Closes: https://lore.kernel.org/lkml/CAHk-=wjWc5dzcj2O1tEgNHY1rnQW63JwtuZi_vAZPqy6wqpoUQ@mail.gmail.com/ Acked-by: Jeff Johnson <[email protected]> # drivers/net/wireless/ath Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bartosz Golaszewski <[email protected]>
1 parent a19ce32 commit ed70aaa

File tree

4 files changed

+6
-8
lines changed

4 files changed

+6
-8
lines changed

arch/arm64/Kconfig.platforms

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -267,6 +267,7 @@ config ARCH_QCOM
267267
bool "Qualcomm Platforms"
268268
select GPIOLIB
269269
select PINCTRL
270+
select HAVE_PWRCTL
270271
help
271272
This enables support for the ARMv8 based Qualcomm chipsets.
272273

drivers/net/wireless/ath/ath11k/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ config ATH11K_PCI
2424
select MHI_BUS
2525
select QRTR
2626
select QRTR_MHI
27+
select PCI_PWRCTL_PWRSEQ if HAVE_PWRCTL
2728
help
2829
This module adds support for PCIE bus
2930

drivers/net/wireless/ath/ath12k/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ config ATH12K
77
select MHI_BUS
88
select QRTR
99
select QRTR_MHI
10+
select PCI_PWRCTL_PWRSEQ if HAVE_PWRCTL
1011
help
1112
Enable support for Qualcomm Technologies Wi-Fi 7 (IEEE
1213
802.11be) family of chipsets, for example WCN7850 and

drivers/pci/pwrctl/Kconfig

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,12 @@
11
# SPDX-License-Identifier: GPL-2.0-only
22

3-
menu "PCI Power control drivers"
3+
config HAVE_PWRCTL
4+
bool
45

56
config PCI_PWRCTL
67
tristate
78

89
config PCI_PWRCTL_PWRSEQ
9-
tristate "PCI Power Control driver using the Power Sequencing subsystem"
10+
tristate
1011
select POWER_SEQUENCING
1112
select PCI_PWRCTL
12-
default m if ((ATH11K_PCI || ATH12K) && ARCH_QCOM)
13-
help
14-
Enable support for the PCI power control driver for device
15-
drivers using the Power Sequencing subsystem.
16-
17-
endmenu

0 commit comments

Comments
 (0)