Skip to content

Commit edf79ef

Browse files
author
Trond Myklebust
committed
NFS: Remove a bogus flag setting in pnfs_write_done_resend_to_mds
Since pnfs_write_done_resend_to_mds() does not actually call end_page_writeback() on the pages that are being redirected to the metadata server, callers of fsync() do not see the I/O as complete until the writeback to the MDS finishes. We therefore do not need to set NFS_CONTEXT_RESEND_WRITES, since there is nothing to redrive. Signed-off-by: Trond Myklebust <[email protected]>
1 parent 67f4b5d commit edf79ef

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

fs/nfs/pnfs.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2817,7 +2817,6 @@ int pnfs_write_done_resend_to_mds(struct nfs_pgio_header *hdr)
28172817
/* Resend all requests through the MDS */
28182818
nfs_pageio_init_write(&pgio, hdr->inode, FLUSH_STABLE, true,
28192819
hdr->completion_ops);
2820-
set_bit(NFS_CONTEXT_RESEND_WRITES, &hdr->args.context->flags);
28212820
return nfs_pageio_resend(&pgio, hdr);
28222821
}
28232822
EXPORT_SYMBOL_GPL(pnfs_write_done_resend_to_mds);

0 commit comments

Comments
 (0)