Skip to content

Commit edfa0b1

Browse files
DaveWysochanskiRHTrond Myklebust
authored andcommitted
NFS: Add offset to nfs_aop_readahead tracepoint
Add the byte offset of the readahead request to the tracepoint output so we know where the read starts. Before this patch: cat-8104 [002] ..... 813.168775: nfs_aop_readahead: fileid=00:31:141 fhandle=0xe55807f6 version=1756509392533525500 nr_pages=256 cat-8104 [002] ..... 813.174973: nfs_aop_readahead_done: fileid=00:31:141 fhandle=0xe55807f6 version=1756509392533525500 nr_pages=256 ret=0 cat-8104 [002] ..... 813.175963: nfs_aop_readahead: fileid=00:31:141 fhandle=0xe55807f6 version=1756509392533525500 nr_pages=256 cat-8104 [002] ..... 813.183742: nfs_aop_readahead_done: fileid=00:31:141 fhandle=0xe55807f6 version=1756509392533525500 nr_pages=1 ret=0 After this patch: cat-6392 [001] ..... 73.107782: nfs_aop_readahead: fileid=00:31:141 fhandle=0xed22403f version=1756511950029502774 offset=5242880 nr_pages=256 cat-6392 [001] ..... 73.112466: nfs_aop_readahead_done: fileid=00:31:141 fhandle=0xed22403f version=1756511950029502774 nr_pages=256 ret=0 cat-6392 [001] ..... 73.115692: nfs_aop_readahead: fileid=00:31:141 fhandle=0xed22403f version=1756511950029502774 offset=6291456 nr_pages=256 cat-6392 [001] ..... 73.123283: nfs_aop_readahead_done: fileid=00:31:141 fhandle=0xed22403f version=1756511950029502774 nr_pages=256 ret=0 Signed-off-by: Dave Wysochanski <[email protected]> Signed-off-by: Trond Myklebust <[email protected]>
1 parent cb5a967 commit edfa0b1

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

fs/nfs/nfstrace.h

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -889,16 +889,18 @@ TRACE_EVENT(nfs_aop_readpage_done,
889889
TRACE_EVENT(nfs_aop_readahead,
890890
TP_PROTO(
891891
const struct inode *inode,
892+
struct page *page,
892893
unsigned int nr_pages
893894
),
894895

895-
TP_ARGS(inode, nr_pages),
896+
TP_ARGS(inode, page, nr_pages),
896897

897898
TP_STRUCT__entry(
898899
__field(dev_t, dev)
899900
__field(u32, fhandle)
900901
__field(u64, fileid)
901902
__field(u64, version)
903+
__field(loff_t, offset)
902904
__field(unsigned int, nr_pages)
903905
),
904906

@@ -909,15 +911,16 @@ TRACE_EVENT(nfs_aop_readahead,
909911
__entry->fileid = nfsi->fileid;
910912
__entry->fhandle = nfs_fhandle_hash(&nfsi->fh);
911913
__entry->version = inode_peek_iversion_raw(inode);
914+
__entry->offset = page_index(page) << PAGE_SHIFT;
912915
__entry->nr_pages = nr_pages;
913916
),
914917

915918
TP_printk(
916-
"fileid=%02x:%02x:%llu fhandle=0x%08x version=%llu nr_pages=%u",
919+
"fileid=%02x:%02x:%llu fhandle=0x%08x version=%llu offset=%lld nr_pages=%u",
917920
MAJOR(__entry->dev), MINOR(__entry->dev),
918921
(unsigned long long)__entry->fileid,
919922
__entry->fhandle, __entry->version,
920-
__entry->nr_pages
923+
__entry->offset, __entry->nr_pages
921924
)
922925
);
923926

@@ -936,6 +939,7 @@ TRACE_EVENT(nfs_aop_readahead_done,
936939
__field(int, ret)
937940
__field(u64, fileid)
938941
__field(u64, version)
942+
__field(loff_t, offset)
939943
__field(unsigned int, nr_pages)
940944
),
941945

fs/nfs/read.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@ int nfs_readpages(struct file *file, struct address_space *mapping,
404404
struct inode *inode = mapping->host;
405405
int ret;
406406

407-
trace_nfs_aop_readahead(inode, nr_pages);
407+
trace_nfs_aop_readahead(inode, lru_to_page(pages), nr_pages);
408408
nfs_inc_stats(inode, NFSIOS_VFSREADPAGES);
409409

410410
ret = -ESTALE;

0 commit comments

Comments
 (0)