Skip to content

Commit ee44d3f

Browse files
geertubroonie
authored andcommitted
spi: sh-msiof: Remove unneeded compatible values
The Clock-Synchronized Serial Interfaces with FIFO (MSIOF) driver matches against both SoC-specific and family-specific compatible values to maintain backwards-compatibility with old DTBs predating the introduction of the family-specific compatible values. For RZ/G1, the SoC-specific compatible match entry can be removed from the driver: their DT always had the family-specific compatible values, and thus there was never a need to add the SoC-specific compatible values to the driver. For R-Car Gen2 and M3-W, the SoC-specific compatible match entries can be removed, too, as there are a few points in time where DT backwards-compatibility was broken for other reasons: - Legacy DT clock support is no longer supported since commit 5825614 ("clk: renesas: Remove R-Car Gen2 legacy DT clock support") in v5.5, and the addition of "renesas,rcar-gen2-msiof" to DTS in v4.11 predates the completion of the clock conversion in v4.15, - Legacy DT LVDS support is no longer supported since commit 841281f ("drm: rcar-du: Drop LVDS device tree backward compatibility") in v5.18, and the addition of "renesas,rcar-gen3-msiof" in commit 8b51f97 ("arm64: dts: r8a7796: Use R-Car Gen 3 fallback binding for msiof nodes") in v4.11 predates the LVDS conversion in commit 58e8ed2 ("arm64: dts: renesas: Convert to new LVDS DT bindings") in v4.20. For R-Car H3, the SoC-specific compatible match entry cannot be removed, as its purpose is to handle an SoC-specific quirk. Suggested-by: Kuninori Morimoto <[email protected]> Signed-off-by: Geert Uytterhoeven <[email protected]> Link: https://patch.msgid.link/d33393ac7536bc3f0f624b079f70d80dd19843db.1747401908.git.geert+renesas@glider.be Signed-off-by: Mark Brown <[email protected]>
1 parent 0e1c7d0 commit ee44d3f

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

drivers/spi/spi-sh-msiof.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1088,16 +1088,8 @@ static const struct sh_msiof_chipdata rcar_r8a7795_data = {
10881088

10891089
static const struct of_device_id sh_msiof_match[] __maybe_unused = {
10901090
{ .compatible = "renesas,sh-mobile-msiof", .data = &sh_data },
1091-
{ .compatible = "renesas,msiof-r8a7743", .data = &rcar_gen2_data },
1092-
{ .compatible = "renesas,msiof-r8a7745", .data = &rcar_gen2_data },
1093-
{ .compatible = "renesas,msiof-r8a7790", .data = &rcar_gen2_data },
1094-
{ .compatible = "renesas,msiof-r8a7791", .data = &rcar_gen2_data },
1095-
{ .compatible = "renesas,msiof-r8a7792", .data = &rcar_gen2_data },
1096-
{ .compatible = "renesas,msiof-r8a7793", .data = &rcar_gen2_data },
1097-
{ .compatible = "renesas,msiof-r8a7794", .data = &rcar_gen2_data },
10981091
{ .compatible = "renesas,rcar-gen2-msiof", .data = &rcar_gen2_data },
10991092
{ .compatible = "renesas,msiof-r8a7795", .data = &rcar_r8a7795_data },
1100-
{ .compatible = "renesas,msiof-r8a7796", .data = &rcar_gen3_data },
11011093
{ .compatible = "renesas,rcar-gen3-msiof", .data = &rcar_gen3_data },
11021094
{ .compatible = "renesas,rcar-gen4-msiof", .data = &rcar_gen3_data },
11031095
{ .compatible = "renesas,sh-msiof", .data = &sh_data }, /* Deprecated */

0 commit comments

Comments
 (0)