Skip to content

Commit ee611e5

Browse files
Robert Richterdjbw
authored andcommitted
cxl/mbox: Add debug messages for enabled mailbox commands
Only unsupported mailbox commands are reported in debug messages. A list of enabled commands is useful too. Change debug messages to also report the opcodes of enabled commands. Esp. if card initialization fails there is no way to get this information from userland. On that occasion also add missing trailing newlines. Signed-off-by: Robert Richter <[email protected]> Reviewed-by: Alison Schofield <[email protected]> Reviewed-by: Jonathan Cameron <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Dan Williams <[email protected]>
1 parent 172738b commit ee611e5

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/cxl/core/mbox.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -610,11 +610,12 @@ static void cxl_walk_cel(struct cxl_dev_state *cxlds, size_t size, u8 *cel)
610610

611611
if (!cmd) {
612612
dev_dbg(cxlds->dev,
613-
"Opcode 0x%04x unsupported by driver", opcode);
613+
"Opcode 0x%04x unsupported by driver\n", opcode);
614614
continue;
615615
}
616616

617617
set_bit(cmd->info.id, cxlds->enabled_cmds);
618+
dev_dbg(cxlds->dev, "Opcode 0x%04x enabled\n", opcode);
618619
}
619620
}
620621

0 commit comments

Comments
 (0)