Skip to content

Commit ee735aa

Browse files
NaRaK-AK47jic23
authored andcommitted
iio: light: Add check for array bounds in veml6075_read_int_time_ms
The array contains only 5 elements, but the index calculated by veml6075_read_int_time_index can range from 0 to 7, which could lead to out-of-bounds access. The check prevents this issue. Coverity Issue CID 1574309: (#1 of 1): Out-of-bounds read (OVERRUN) overrun-local: Overrunning array veml6075_it_ms of 5 4-byte elements at element index 7 (byte offset 31) using index int_index (which evaluates to 7) This is hardening against potentially broken hardware. Good to have but not necessary to backport. Fixes: 3b82f43 ("iio: light: add VEML6075 UVA and UVB light sensor driver") Signed-off-by: Karan Sanghavi <[email protected]> Reviewed-by: Javier Carrasco <[email protected]> Link: https://patch.msgid.link/Z7dnrEpKQdRZ2qFU@Emma Signed-off-by: Jonathan Cameron <[email protected]>
1 parent 8d53427 commit ee735aa

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

drivers/iio/light/veml6075.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,13 +195,17 @@ static int veml6075_read_uv_direct(struct veml6075_data *data, int chan,
195195

196196
static int veml6075_read_int_time_index(struct veml6075_data *data)
197197
{
198-
int ret, conf;
198+
int ret, conf, int_index;
199199

200200
ret = regmap_read(data->regmap, VEML6075_CMD_CONF, &conf);
201201
if (ret < 0)
202202
return ret;
203203

204-
return FIELD_GET(VEML6075_CONF_IT, conf);
204+
int_index = FIELD_GET(VEML6075_CONF_IT, conf);
205+
if (int_index >= ARRAY_SIZE(veml6075_it_ms))
206+
return -EINVAL;
207+
208+
return int_index;
205209
}
206210

207211
static int veml6075_read_int_time_ms(struct veml6075_data *data, int *val)

0 commit comments

Comments
 (0)