Skip to content

Commit ee896ee

Browse files
vwaxrostedt
authored andcommitted
tracing: Remove outdated comment in stack handling
This comment describes the behaviour before commit 2a820bf ("tracing: Use percpu stack trace buffer more intelligently"). Since that commit, interrupts and NMIs do use the per-cpu stacks so the comment is no longer correct. Remove it. (Note that the FTRACE_STACK_SIZE mentioned in the comment has never existed, it probably should have said FTRACE_STACK_ENTRIES.) Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Vincent Whitchurch <[email protected]> Signed-off-by: Steven Rostedt (VMware) <[email protected]>
1 parent c5f5157 commit ee896ee

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

kernel/trace/trace.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2930,12 +2930,6 @@ static void __ftrace_trace_stack(struct trace_buffer *buffer,
29302930
skip++;
29312931
#endif
29322932

2933-
/*
2934-
* Since events can happen in NMIs there's no safe way to
2935-
* use the per cpu ftrace_stacks. We reserve it and if an interrupt
2936-
* or NMI comes in, it will just have to use the default
2937-
* FTRACE_STACK_SIZE.
2938-
*/
29392933
preempt_disable_notrace();
29402934

29412935
stackidx = __this_cpu_inc_return(ftrace_stack_reserve) - 1;

0 commit comments

Comments
 (0)