Skip to content

Commit eea6a83

Browse files
Eric Sandeenbrauner
authored andcommitted
fuse: Convert to new uid/gid option parsing helpers
Convert to new uid/gid option parsing helpers Signed-off-by: Eric Sandeen <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Christian Brauner <[email protected]> Reviewed-by: Josef Bacik <[email protected]> Signed-off-by: Christian Brauner <[email protected]>
1 parent 525bd65 commit eea6a83

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

fs/fuse/inode.c

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -740,8 +740,8 @@ static const struct fs_parameter_spec fuse_fs_parameters[] = {
740740
fsparam_string ("source", OPT_SOURCE),
741741
fsparam_u32 ("fd", OPT_FD),
742742
fsparam_u32oct ("rootmode", OPT_ROOTMODE),
743-
fsparam_u32 ("user_id", OPT_USER_ID),
744-
fsparam_u32 ("group_id", OPT_GROUP_ID),
743+
fsparam_uid ("user_id", OPT_USER_ID),
744+
fsparam_gid ("group_id", OPT_GROUP_ID),
745745
fsparam_flag ("default_permissions", OPT_DEFAULT_PERMISSIONS),
746746
fsparam_flag ("allow_other", OPT_ALLOW_OTHER),
747747
fsparam_u32 ("max_read", OPT_MAX_READ),
@@ -801,9 +801,7 @@ static int fuse_parse_param(struct fs_context *fsc, struct fs_parameter *param)
801801
break;
802802

803803
case OPT_USER_ID:
804-
kuid = make_kuid(fsc->user_ns, result.uint_32);
805-
if (!uid_valid(kuid))
806-
return invalfc(fsc, "Invalid user_id");
804+
kuid = result.uid;
807805
/*
808806
* The requested uid must be representable in the
809807
* filesystem's idmapping.
@@ -815,9 +813,7 @@ static int fuse_parse_param(struct fs_context *fsc, struct fs_parameter *param)
815813
break;
816814

817815
case OPT_GROUP_ID:
818-
kgid = make_kgid(fsc->user_ns, result.uint_32);;
819-
if (!gid_valid(kgid))
820-
return invalfc(fsc, "Invalid group_id");
816+
kgid = result.gid;
821817
/*
822818
* The requested gid must be representable in the
823819
* filesystem's idmapping.

0 commit comments

Comments
 (0)