Skip to content

Commit eef5bcc

Browse files
Shenghao-Dingtiwai
authored andcommitted
ALSA: hda/tas2781: Fix the ld issue reported by kernel test robot
After commit 9fa6a69 ("ALSA: hda/tas2781: Remove tas2781_spi_fwlib.c and leverage SND_SOC_TAS2781_FMWLIB")created a separated lib for i2c, However, tasdevice_remove() used for not only for I2C but for SPI being still in that lib caused ld issue. All errors (new ones prefixed by >>): >> ld.lld: error: undefined symbol: tasdevice_remove >>> referenced by tas2781_hda.c:33 (sound/pci/hda/tas2781_hda.c:33) >>> vmlinux.o:(tas2781_hda_remove) To fix this issue, the implementation of tasdevice_remove was moved from tas2781-comlib-i2c.c to tas2781-comlib.c. Fixes: 9fa6a69 ("ALSA: hda/tas2781: Remove tas2781_spi_fwlib.c and leverage SND_SOC_TAS2781_FMWLIB") Reported-by: kernel test robot <[email protected]> Closes: https://urldefense.com/v3/__https://lore.kernel.org/oe-kbuild-all/[email protected]/__;!!G3vK!U-wdsvrOG1iezggZ55RYi8ikBxMaJD Signed-off-by: Shenghao Ding <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent 6f174da commit eef5bcc

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

sound/soc/codecs/tas2781-comlib-i2c.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -364,12 +364,6 @@ int tascodec_init(struct tasdevice_priv *tas_priv, void *codec,
364364
}
365365
EXPORT_SYMBOL_GPL(tascodec_init);
366366

367-
void tasdevice_remove(struct tasdevice_priv *tas_priv)
368-
{
369-
mutex_destroy(&tas_priv->codec_lock);
370-
}
371-
EXPORT_SYMBOL_GPL(tasdevice_remove);
372-
373367
MODULE_DESCRIPTION("TAS2781 common library for I2C");
374368
MODULE_AUTHOR("Shenghao Ding, TI, <[email protected]>");
375369
MODULE_LICENSE("GPL");

sound/soc/codecs/tas2781-comlib.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -225,6 +225,12 @@ void tasdevice_dsp_remove(void *context)
225225
}
226226
EXPORT_SYMBOL_GPL(tasdevice_dsp_remove);
227227

228+
void tasdevice_remove(struct tasdevice_priv *tas_priv)
229+
{
230+
mutex_destroy(&tas_priv->codec_lock);
231+
}
232+
EXPORT_SYMBOL_GPL(tasdevice_remove);
233+
228234
MODULE_DESCRIPTION("TAS2781 common library");
229235
MODULE_AUTHOR("Shenghao Ding, TI, <[email protected]>");
230236
MODULE_LICENSE("GPL");

0 commit comments

Comments
 (0)