Skip to content

Commit ef76eb8

Browse files
paravmellanoxmstsirkin
authored andcommitted
vdpa/mlx5: Fix clearing of VIRTIO_NET_F_MAC feature bit
Cited patch in the fixes tag clears the features bit during reset. mlx5 vdpa device feature bits are static decided by device capabilities. These feature bits (including VIRTIO_NET_F_MAC) are initialized during device addition time. Clearing features bit in reset callback cleared the VIRTIO_NET_F_MAC. Due to this, MAC address provided by the device is not honored. Fix it by not clearing the static feature bits during reset. Fixes: 0686082 ("vdpa: Add reset callback in vdpa_config_ops") Signed-off-by: Parav Pandit <[email protected]> Reviewed-by: Eli Cohen <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Michael S. Tsirkin <[email protected]> Acked-by: Jason Wang <[email protected]>
1 parent 1138b98 commit ef76eb8

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/vdpa/mlx5/net/mlx5_vnet.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2194,7 +2194,6 @@ static int mlx5_vdpa_reset(struct vdpa_device *vdev)
21942194
clear_vqs_ready(ndev);
21952195
mlx5_vdpa_destroy_mr(&ndev->mvdev);
21962196
ndev->mvdev.status = 0;
2197-
ndev->mvdev.mlx_features = 0;
21982197
memset(ndev->event_cbs, 0, sizeof(ndev->event_cbs));
21992198
ndev->mvdev.actual_features = 0;
22002199
++mvdev->generation;

0 commit comments

Comments
 (0)