Skip to content

Commit efc3d7d

Browse files
geoffreybennetttiwai
authored andcommitted
ALSA: scarlett2: Rename scarlett_gen2 to scarlett2
This driver was originally developed for the Focusrite Scarlett Gen 2 series. Since then Focusrite have used a similar protocol for their Gen 3, Gen 4, Clarett USB, Clarett+, and Vocaster series. Let's call this common protocol the "Scarlett 2 Protocol" and rename the driver to scarlett2 to not imply that it is restricted to Gen 2 series devices. Signed-off-by: Geoffrey D. Bennett <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent 76c1218 commit efc3d7d

File tree

6 files changed

+18
-16
lines changed

6 files changed

+18
-16
lines changed

MAINTAINERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8126,7 +8126,7 @@ M: Geoffrey D. Bennett <[email protected]>
81268126
L: [email protected] (moderated for non-subscribers)
81278127
S: Maintained
81288128
T: git git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
8129-
F: sound/usb/mixer_scarlett_gen2.c
8129+
F: sound/usb/mixer_scarlett2.c
81308130

81318131
FORCEDETH GIGABIT ETHERNET DRIVER
81328132
M: Rain River <[email protected]>

sound/usb/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ snd-usb-audio-objs := card.o \
1212
mixer.o \
1313
mixer_quirks.o \
1414
mixer_scarlett.o \
15-
mixer_scarlett_gen2.o \
15+
mixer_scarlett2.o \
1616
mixer_us16x08.o \
1717
mixer_s1810c.o \
1818
pcm.o \

sound/usb/mixer_quirks.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
#include "mixer.h"
3434
#include "mixer_quirks.h"
3535
#include "mixer_scarlett.h"
36-
#include "mixer_scarlett_gen2.h"
36+
#include "mixer_scarlett2.h"
3737
#include "mixer_us16x08.h"
3838
#include "mixer_s1810c.h"
3939
#include "helper.h"
@@ -3426,7 +3426,7 @@ int snd_usb_mixer_apply_create_quirk(struct usb_mixer_interface *mixer)
34263426
case USB_ID(0x1235, 0x820a): /* Focusrite Clarett+ 2Pre */
34273427
case USB_ID(0x1235, 0x820b): /* Focusrite Clarett+ 4Pre */
34283428
case USB_ID(0x1235, 0x820c): /* Focusrite Clarett+ 8Pre */
3429-
err = snd_scarlett_gen2_init(mixer);
3429+
err = snd_scarlett2_init(mixer);
34303430
break;
34313431

34323432
case USB_ID(0x041e, 0x323b): /* Creative Sound Blaster E1 */

sound/usb/mixer_scarlett_gen2.c renamed to sound/usb/mixer_scarlett2.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
// SPDX-License-Identifier: GPL-2.0
22
/*
3-
* Focusrite Scarlett Gen 2/3 and Clarett USB/Clarett+ Driver for ALSA
3+
* Focusrite Scarlett 2 Protocol Driver for ALSA
4+
* (including Scarlett 2nd Gen, 3rd Gen, Clarett USB, and Clarett+
5+
* series products)
46
*
57
* Supported models:
68
* - 6i6/18i8/18i20 Gen 2
@@ -149,7 +151,7 @@
149151
#include "mixer.h"
150152
#include "helper.h"
151153

152-
#include "mixer_scarlett_gen2.h"
154+
#include "mixer_scarlett2.h"
153155

154156
/* device_setup value to allow turning MSD mode back on */
155157
#define SCARLETT2_MSD_ENABLE 0x02
@@ -4174,7 +4176,7 @@ static const struct scarlett2_device_entry *get_scarlett2_device_entry(
41744176
return entry;
41754177
}
41764178

4177-
static int snd_scarlett_gen2_controls_create(
4179+
static int snd_scarlett2_controls_create(
41784180
struct usb_mixer_interface *mixer,
41794181
const struct scarlett2_device_entry *entry)
41804182
{
@@ -4262,7 +4264,7 @@ static int snd_scarlett_gen2_controls_create(
42624264
return 0;
42634265
}
42644266

4265-
int snd_scarlett_gen2_init(struct usb_mixer_interface *mixer)
4267+
int snd_scarlett2_init(struct usb_mixer_interface *mixer)
42664268
{
42674269
struct snd_usb_audio *chip = mixer->chip;
42684270
const struct scarlett2_device_entry *entry;
@@ -4301,7 +4303,7 @@ int snd_scarlett_gen2_init(struct usb_mixer_interface *mixer)
43014303
entry->series_name,
43024304
USB_ID_PRODUCT(chip->usb_id));
43034305

4304-
err = snd_scarlett_gen2_controls_create(mixer, entry);
4306+
err = snd_scarlett2_controls_create(mixer, entry);
43054307
if (err < 0)
43064308
usb_audio_err(mixer->chip,
43074309
"Error initialising %s Mixer Driver: %d",

sound/usb/mixer_scarlett2.h

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
/* SPDX-License-Identifier: GPL-2.0 */
2+
#ifndef __USB_MIXER_SCARLETT2_H
3+
#define __USB_MIXER_SCARLETT2_H
4+
5+
int snd_scarlett2_init(struct usb_mixer_interface *mixer);
6+
7+
#endif /* __USB_MIXER_SCARLETT2_H */

sound/usb/mixer_scarlett_gen2.h

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)