Skip to content

Commit f04dba6

Browse files
committed
Merge tag 'char-misc-5.5-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
Pull char/misc fixes from Greg KH: "Here are some small fixes for 5.5-rc7 Included here are: - two lkdtm fixes - coresight build fix - Documentation update for the hw process document All of these have been in linux-next with no reported issues" * tag 'char-misc-5.5-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc: Documentation/process: Add Amazon contact for embargoed hardware issues lkdtm/bugs: fix build error in lkdtm_UNSET_SMEP lkdtm/bugs: Make double-fault test always available coresight: etm4x: Fix unused function warning
2 parents bf3f401 + fb85145 commit f04dba6

File tree

3 files changed

+14
-13
lines changed

3 files changed

+14
-13
lines changed

Documentation/process/embargoed-hardware-issues.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ an involved disclosed party. The current ambassadors list:
255255
Red Hat Josh Poimboeuf <[email protected]>
256256
SUSE Jiri Kosina <[email protected]>
257257

258-
Amazon
258+
Amazon Peter Bowen <[email protected]>
259259
Google Kees Cook <[email protected]>
260260
============= ========================================================
261261

drivers/hwtracing/coresight/coresight-etm4x.c

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1132,7 +1132,6 @@ static void etm4_init_trace_id(struct etmv4_drvdata *drvdata)
11321132
drvdata->trcid = coresight_get_trace_id(drvdata->cpu);
11331133
}
11341134

1135-
#ifdef CONFIG_CPU_PM
11361135
static int etm4_cpu_save(struct etmv4_drvdata *drvdata)
11371136
{
11381137
int i, ret = 0;
@@ -1402,17 +1401,17 @@ static struct notifier_block etm4_cpu_pm_nb = {
14021401

14031402
static int etm4_cpu_pm_register(void)
14041403
{
1405-
return cpu_pm_register_notifier(&etm4_cpu_pm_nb);
1404+
if (IS_ENABLED(CONFIG_CPU_PM))
1405+
return cpu_pm_register_notifier(&etm4_cpu_pm_nb);
1406+
1407+
return 0;
14061408
}
14071409

14081410
static void etm4_cpu_pm_unregister(void)
14091411
{
1410-
cpu_pm_unregister_notifier(&etm4_cpu_pm_nb);
1412+
if (IS_ENABLED(CONFIG_CPU_PM))
1413+
cpu_pm_unregister_notifier(&etm4_cpu_pm_nb);
14111414
}
1412-
#else
1413-
static int etm4_cpu_pm_register(void) { return 0; }
1414-
static void etm4_cpu_pm_unregister(void) { }
1415-
#endif
14161415

14171416
static int etm4_probe(struct amba_device *adev, const struct amba_id *id)
14181417
{

drivers/misc/lkdtm/bugs.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ void lkdtm_STACK_GUARD_PAGE_TRAILING(void)
278278

279279
void lkdtm_UNSET_SMEP(void)
280280
{
281-
#ifdef CONFIG_X86_64
281+
#if IS_ENABLED(CONFIG_X86_64) && !IS_ENABLED(CONFIG_UML)
282282
#define MOV_CR4_DEPTH 64
283283
void (*direct_write_cr4)(unsigned long val);
284284
unsigned char *insn;
@@ -338,13 +338,13 @@ void lkdtm_UNSET_SMEP(void)
338338
native_write_cr4(cr4);
339339
}
340340
#else
341-
pr_err("FAIL: this test is x86_64-only\n");
341+
pr_err("XFAIL: this test is x86_64-only\n");
342342
#endif
343343
}
344344

345-
#ifdef CONFIG_X86_32
346345
void lkdtm_DOUBLE_FAULT(void)
347346
{
347+
#ifdef CONFIG_X86_32
348348
/*
349349
* Trigger #DF by setting the stack limit to zero. This clobbers
350350
* a GDT TLS slot, which is okay because the current task will die
@@ -373,6 +373,8 @@ void lkdtm_DOUBLE_FAULT(void)
373373
asm volatile ("movw %0, %%ss; addl $0, (%%esp)" ::
374374
"r" ((unsigned short)(GDT_ENTRY_TLS_MIN << 3)));
375375

376-
panic("tried to double fault but didn't die\n");
377-
}
376+
pr_err("FAIL: tried to double fault but didn't die\n");
377+
#else
378+
pr_err("XFAIL: this test is ia32-only\n");
378379
#endif
380+
}

0 commit comments

Comments
 (0)