Skip to content

Commit f069ede

Browse files
diandersandersson
authored andcommitted
arm64: dts: qcom: sc7280: Power herobrine's 3.3 eDP/TS rail more properly
This is the equivalent of commit f5b4811 ("arm64: dts: qcom: sc7180: Add trogdor eDP/touchscreen regulator off-on-time") and commit 23ff866 ("arm64: dts: qcom: sc7180: Start the trogdor eDP/touchscreen regulator on"), but for herobrine instead of trogdor. The motivations for herobrine are the same as for trogdor. NOTES: * Currently for herobrine all boards are eDP, not MIPI. If/when we have herobrine derivatives that are MIPI they we can evaluate whether the same off-on-delay makes sense for them. For trogdor we didn't add the delay to MIPI panels because the problem was found late and nobody had complained about it. For herobrine defaulting to assuming the same 500ms makes sense and if we find we need to optimize later we can. * Currently there are no oddball herobrine boards like homestar where the panel really likes to be power cycled. If we have an oddball board it will need to split the eDP and touchscreen rail anyway (like homestar did) and we'll have to delete the "regulator-boot-on" from that board. Signed-off-by: Douglas Anderson <[email protected]> Reviewed-by: Matthias Kaehlcke <[email protected]> Reviewed-by: Konrad Dybcio <[email protected]> Signed-off-by: Bjorn Andersson <[email protected]> Link: https://lore.kernel.org/r/20230207163550.1.I5ff72b7746d5fca8f10ea61351bde4150ed1a7f8@changeid
1 parent 12efdee commit f069ede

File tree

1 file changed

+16
-0
lines changed

1 file changed

+16
-0
lines changed

arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,22 @@
110110

111111
regulator-enable-ramp-delay = <3000>;
112112

113+
/*
114+
* eDP panel specs nearly always have a spec that says you
115+
* shouldn't turn them off an on again without waiting 500ms.
116+
* Add this as a board constraint since this rail is shared
117+
* between the panel and touchscreen.
118+
*/
119+
off-on-delay-us = <500000>;
120+
121+
/*
122+
* Stat the regulator on. This has the advantage of starting
123+
* the slow process of powering the panel on as soon as we
124+
* probe the regulator. It also avoids tripping the
125+
* off-on-delay immediately on every bootup.
126+
*/
127+
regulator-boot-on;
128+
113129
vin-supply = <&pp3300_z1>;
114130
};
115131

0 commit comments

Comments
 (0)