Skip to content

Commit f0a353b

Browse files
Colin Ian Kingdlezcano
authored andcommitted
drivers: thermal: tsens: fix potential integer overflow on multiply
Currently a multiply operation is being performed on two int values and the result is being assigned to a u64, presumably because the end result is expected to be probably larger than an int. However, because the multiply is an int multiply one can get overflow. Avoid the overflow by casting degc to a u64 to force a u64 multiply. Also use div_u64 for the divide as suggested by Daniel Lezcano. Addresses-Coverity: ("Unintentional integer overflow") Fixes: fbfe1a0 ("drivers: thermal: tsens: Add interrupt support") Signed-off-by: Colin Ian King <[email protected]> Signed-off-by: Daniel Lezcano <[email protected]> Reviewed-by: Amit Kucheria <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 0cac755 commit f0a353b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/thermal/qcom/tsens-common.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ void compute_intercept_slope(struct tsens_priv *priv, u32 *p1,
9292

9393
static inline u32 degc_to_code(int degc, const struct tsens_sensor *s)
9494
{
95-
u64 code = (degc * s->slope + s->offset) / SLOPE_FACTOR;
95+
u64 code = div_u64(((u64)degc * s->slope + s->offset), SLOPE_FACTOR);
9696

9797
pr_debug("%s: raw_code: 0x%llx, degc:%d\n", __func__, code, degc);
9898
return clamp_val(code, THRESHOLD_MIN_ADC_CODE, THRESHOLD_MAX_ADC_CODE);

0 commit comments

Comments
 (0)