Skip to content

Commit f0df68d

Browse files
jwrdegoedeardbiesheuvel
authored andcommitted
efi: Add embedded peripheral firmware support
Just like with PCI options ROMs, which we save in the setup_efi_pci* functions from arch/x86/boot/compressed/eboot.c, the EFI code / ROM itself sometimes may contain data which is useful/necessary for peripheral drivers to have access to. Specifically the EFI code may contain an embedded copy of firmware which needs to be (re)loaded into the peripheral. Normally such firmware would be part of linux-firmware, but in some cases this is not feasible, for 2 reasons: 1) The firmware is customized for a specific use-case of the chipset / use with a specific hardware model, so we cannot have a single firmware file for the chipset. E.g. touchscreen controller firmwares are compiled specifically for the hardware model they are used with, as they are calibrated for a specific model digitizer. 2) Despite repeated attempts we have failed to get permission to redistribute the firmware. This is especially a problem with customized firmwares, these get created by the chip vendor for a specific ODM and the copyright may partially belong with the ODM, so the chip vendor cannot give a blanket permission to distribute these. This commit adds support for finding peripheral firmware embedded in the EFI code and makes the found firmware available through the new efi_get_embedded_fw() function. Support for loading these firmwares through the standard firmware loading mechanism is added in a follow-up commit in this patch-series. Note we check the EFI_BOOT_SERVICES_CODE for embedded firmware near the end of start_kernel(), just before calling rest_init(), this is on purpose because the typical EFI_BOOT_SERVICES_CODE memory-segment is too large for early_memremap(), so the check must be done after mm_init(). This relies on EFI_BOOT_SERVICES_CODE not being free-ed until efi_free_boot_services() is called, which means that this will only work on x86 for now. Reported-by: Dave Olsthoorn <[email protected]> Suggested-by: Peter Jones <[email protected]> Acked-by: Ard Biesheuvel <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Ard Biesheuvel <[email protected]>
1 parent 0e72a6a commit f0df68d

File tree

6 files changed

+201
-0
lines changed

6 files changed

+201
-0
lines changed

arch/x86/platform/efi/efi.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -944,6 +944,7 @@ static void __init __efi_enter_virtual_mode(void)
944944
goto err;
945945
}
946946

947+
efi_check_for_embedded_firmwares();
947948
efi_free_boot_services();
948949

949950
/*

drivers/firmware/efi/Kconfig

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,11 @@ config EFI_DISABLE_PCI_DMA
239239

240240
endmenu
241241

242+
config EFI_EMBEDDED_FIRMWARE
243+
bool
244+
depends on EFI
245+
select CRYPTO_LIB_SHA256
246+
242247
config UEFI_CPER
243248
bool
244249

drivers/firmware/efi/Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ obj-$(CONFIG_EFI_TEST) += test/
2626
obj-$(CONFIG_EFI_DEV_PATH_PARSER) += dev-path-parser.o
2727
obj-$(CONFIG_APPLE_PROPERTIES) += apple-properties.o
2828
obj-$(CONFIG_EFI_RCI2_TABLE) += rci2-table.o
29+
obj-$(CONFIG_EFI_EMBEDDED_FIRMWARE) += embedded-firmware.o
2930

3031
fake_map-y += fake_mem.o
3132
fake_map-$(CONFIG_X86) += x86_fake_mem.o
Lines changed: 147 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,147 @@
1+
// SPDX-License-Identifier: GPL-2.0
2+
/*
3+
* Support for extracting embedded firmware for peripherals from EFI code,
4+
*
5+
* Copyright (c) 2018 Hans de Goede <[email protected]>
6+
*/
7+
8+
#include <linux/dmi.h>
9+
#include <linux/efi.h>
10+
#include <linux/efi_embedded_fw.h>
11+
#include <linux/io.h>
12+
#include <linux/slab.h>
13+
#include <linux/types.h>
14+
#include <linux/vmalloc.h>
15+
#include <crypto/sha.h>
16+
17+
/* Exported for use by lib/test_firmware.c only */
18+
LIST_HEAD(efi_embedded_fw_list);
19+
EXPORT_SYMBOL_GPL(efi_embedded_fw_list);
20+
21+
static bool checked_for_fw;
22+
23+
static const struct dmi_system_id * const embedded_fw_table[] = {
24+
NULL
25+
};
26+
27+
/*
28+
* Note the efi_check_for_embedded_firmwares() code currently makes the
29+
* following 2 assumptions. This may needs to be revisited if embedded firmware
30+
* is found where this is not true:
31+
* 1) The firmware is only found in EFI_BOOT_SERVICES_CODE memory segments
32+
* 2) The firmware always starts at an offset which is a multiple of 8 bytes
33+
*/
34+
static int __init efi_check_md_for_embedded_firmware(
35+
efi_memory_desc_t *md, const struct efi_embedded_fw_desc *desc)
36+
{
37+
struct sha256_state sctx;
38+
struct efi_embedded_fw *fw;
39+
u8 sha256[32];
40+
u64 i, size;
41+
u8 *map;
42+
43+
size = md->num_pages << EFI_PAGE_SHIFT;
44+
map = memremap(md->phys_addr, size, MEMREMAP_WB);
45+
if (!map) {
46+
pr_err("Error mapping EFI mem at %#llx\n", md->phys_addr);
47+
return -ENOMEM;
48+
}
49+
50+
for (i = 0; (i + desc->length) <= size; i += 8) {
51+
if (memcmp(map + i, desc->prefix, EFI_EMBEDDED_FW_PREFIX_LEN))
52+
continue;
53+
54+
sha256_init(&sctx);
55+
sha256_update(&sctx, map + i, desc->length);
56+
sha256_final(&sctx, sha256);
57+
if (memcmp(sha256, desc->sha256, 32) == 0)
58+
break;
59+
}
60+
if ((i + desc->length) > size) {
61+
memunmap(map);
62+
return -ENOENT;
63+
}
64+
65+
pr_info("Found EFI embedded fw '%s'\n", desc->name);
66+
67+
fw = kmalloc(sizeof(*fw), GFP_KERNEL);
68+
if (!fw) {
69+
memunmap(map);
70+
return -ENOMEM;
71+
}
72+
73+
fw->data = kmemdup(map + i, desc->length, GFP_KERNEL);
74+
memunmap(map);
75+
if (!fw->data) {
76+
kfree(fw);
77+
return -ENOMEM;
78+
}
79+
80+
fw->name = desc->name;
81+
fw->length = desc->length;
82+
list_add(&fw->list, &efi_embedded_fw_list);
83+
84+
return 0;
85+
}
86+
87+
void __init efi_check_for_embedded_firmwares(void)
88+
{
89+
const struct efi_embedded_fw_desc *fw_desc;
90+
const struct dmi_system_id *dmi_id;
91+
efi_memory_desc_t *md;
92+
int i, r;
93+
94+
for (i = 0; embedded_fw_table[i]; i++) {
95+
dmi_id = dmi_first_match(embedded_fw_table[i]);
96+
if (!dmi_id)
97+
continue;
98+
99+
fw_desc = dmi_id->driver_data;
100+
101+
/*
102+
* In some drivers the struct driver_data contains may contain
103+
* other driver specific data after the fw_desc struct; and
104+
* the fw_desc struct itself may be empty, skip these.
105+
*/
106+
if (!fw_desc->name)
107+
continue;
108+
109+
for_each_efi_memory_desc(md) {
110+
if (md->type != EFI_BOOT_SERVICES_CODE)
111+
continue;
112+
113+
r = efi_check_md_for_embedded_firmware(md, fw_desc);
114+
if (r == 0)
115+
break;
116+
}
117+
}
118+
119+
checked_for_fw = true;
120+
}
121+
122+
int efi_get_embedded_fw(const char *name, const u8 **data, size_t *size)
123+
{
124+
struct efi_embedded_fw *iter, *fw = NULL;
125+
126+
if (!checked_for_fw) {
127+
pr_warn("Warning %s called while we did not check for embedded fw\n",
128+
__func__);
129+
return -ENOENT;
130+
}
131+
132+
list_for_each_entry(iter, &efi_embedded_fw_list, list) {
133+
if (strcmp(name, iter->name) == 0) {
134+
fw = iter;
135+
break;
136+
}
137+
}
138+
139+
if (!fw)
140+
return -ENOENT;
141+
142+
*data = fw->data;
143+
*size = fw->length;
144+
145+
return 0;
146+
}
147+
EXPORT_SYMBOL_GPL(efi_get_embedded_fw);

include/linux/efi.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1554,6 +1554,12 @@ static inline void
15541554
efi_enable_reset_attack_mitigation(void) { }
15551555
#endif
15561556

1557+
#ifdef CONFIG_EFI_EMBEDDED_FIRMWARE
1558+
void efi_check_for_embedded_firmwares(void);
1559+
#else
1560+
static inline void efi_check_for_embedded_firmwares(void) { }
1561+
#endif
1562+
15571563
efi_status_t efi_random_get_seed(void);
15581564

15591565
void efi_retrieve_tpm2_eventlog(void);

include/linux/efi_embedded_fw.h

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
/* SPDX-License-Identifier: GPL-2.0 */
2+
#ifndef _LINUX_EFI_EMBEDDED_FW_H
3+
#define _LINUX_EFI_EMBEDDED_FW_H
4+
5+
#include <linux/list.h>
6+
#include <linux/mod_devicetable.h>
7+
8+
#define EFI_EMBEDDED_FW_PREFIX_LEN 8
9+
10+
/*
11+
* This struct and efi_embedded_fw_list are private to the efi-embedded fw
12+
* implementation they are in this header for use by lib/test_firmware.c only!
13+
*/
14+
struct efi_embedded_fw {
15+
struct list_head list;
16+
const char *name;
17+
const u8 *data;
18+
size_t length;
19+
};
20+
21+
extern struct list_head efi_embedded_fw_list;
22+
23+
/**
24+
* struct efi_embedded_fw_desc - This struct is used by the EFI embedded-fw
25+
* code to search for embedded firmwares.
26+
*
27+
* @name: Name to register the firmware with if found
28+
* @prefix: First 8 bytes of the firmware
29+
* @length: Length of the firmware in bytes including prefix
30+
* @sha256: SHA256 of the firmware
31+
*/
32+
struct efi_embedded_fw_desc {
33+
const char *name;
34+
u8 prefix[EFI_EMBEDDED_FW_PREFIX_LEN];
35+
u32 length;
36+
u8 sha256[32];
37+
};
38+
39+
int efi_get_embedded_fw(const char *name, const u8 **dat, size_t *sz);
40+
41+
#endif

0 commit comments

Comments
 (0)