Skip to content

Commit f129660

Browse files
committed
drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_writebacks()
drm_atomic_helper_commit_writebacks() updates all writeback connectors affected by a new commit. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Reviewed-by: Dmitry Baryshkov <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Maxime Ripard <[email protected]>
1 parent 742043c commit f129660

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/gpu/drm/drm_atomic_helper.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1463,13 +1463,13 @@ void drm_atomic_helper_commit_modeset_disables(struct drm_device *dev,
14631463
EXPORT_SYMBOL(drm_atomic_helper_commit_modeset_disables);
14641464

14651465
static void drm_atomic_helper_commit_writebacks(struct drm_device *dev,
1466-
struct drm_atomic_state *old_state)
1466+
struct drm_atomic_state *state)
14671467
{
14681468
struct drm_connector *connector;
14691469
struct drm_connector_state *new_conn_state;
14701470
int i;
14711471

1472-
for_each_new_connector_in_state(old_state, connector, new_conn_state, i) {
1472+
for_each_new_connector_in_state(state, connector, new_conn_state, i) {
14731473
const struct drm_connector_helper_funcs *funcs;
14741474

14751475
funcs = connector->helper_private;
@@ -1478,7 +1478,7 @@ static void drm_atomic_helper_commit_writebacks(struct drm_device *dev,
14781478

14791479
if (new_conn_state->writeback_job && new_conn_state->writeback_job->fb) {
14801480
WARN_ON(connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK);
1481-
funcs->atomic_commit(connector, old_state);
1481+
funcs->atomic_commit(connector, state);
14821482
}
14831483
}
14841484
}

0 commit comments

Comments
 (0)