Skip to content

Commit f15be3d

Browse files
digetxKAGA-KOKO
authored andcommitted
arm64: dts: rockchip: rk356x: Add MSI controller node
Rockchip 356x SoC's GIC has two hardware integration issues that affect MSI functionality of the GIC. Previously, both these GIC issues were worked around by using MBI for MSI instead of ITS because kernel GIC driver didn't have necessary quirks. First issue is about RK356x GIC not supporting programmable shareability, while reporting it as supported in a GIC's feature register. Rockchip assigned Erratum ID #3568001 for this issue. This patch adds dma-noncoherent property to the GIC node, denoting that a SW workaround is required for mitigating the issue. Second issue is about GIC AXI master interface addressing limited to the first 4GB of physical address space. Rockchip assigned Erratum ID #3568002 for this issue. Now that kernel supports quirks for both of the erratums, add MSI controller node to RK356x device-tree. Signed-off-by: Dmitry Osipenko <[email protected]> Signed-off-by: Thomas Gleixner <[email protected]> Link: https://lore.kernel.org/all/[email protected]
1 parent 2d81e1b commit f15be3d

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

arch/arm64/boot/dts/rockchip/rk356x-base.dtsi

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,18 @@
284284
mbi-alias = <0x0 0xfd410000>;
285285
mbi-ranges = <296 24>;
286286
msi-controller;
287+
ranges;
288+
#address-cells = <2>;
289+
#size-cells = <2>;
290+
dma-noncoherent;
291+
292+
its: msi-controller@fd440000 {
293+
compatible = "arm,gic-v3-its";
294+
reg = <0x0 0xfd440000 0 0x20000>;
295+
dma-noncoherent;
296+
msi-controller;
297+
#msi-cells = <1>;
298+
};
287299
};
288300

289301
usb_host0_ehci: usb@fd800000 {

0 commit comments

Comments
 (0)