Skip to content

Commit f17cd48

Browse files
gascoargregkh
authored andcommitted
staging: gpib: fix kernel-doc section for usb_gpib_line_status() function
The function name field in the kernel-doc section for the usb_gpib_line_status() is defined as 'line_status'. In addition, after the kernel-doc section, there are three macro definition instead of the function definition. These issues trigger the warning: warning: expecting prototype for line_status(). Prototype was for WQT() instead. Fix the warning by renaming the function in the kernel-doc section and by moving the macros to the beginning of the file with the rest of macros definition. Signed-off-by: Gaston Gonzalez <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 4ec9b9b commit f17cd48

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,10 @@ module_param(debug, int, 0644);
7878
dev_dbg(board->gpib_dev, format, ## __VA_ARGS__); } \
7979
while (0)
8080

81+
#define WQT wait_queue_entry_t
82+
#define WQH head
83+
#define WQE entry
84+
8185
/* standard and extended command sets of the usb-gpib adapter */
8286

8387
#define USB_GPIB_ON "\nIB\n"
@@ -644,17 +648,12 @@ static void usb_gpib_interface_clear(struct gpib_board *board, int assert)
644648
}
645649

646650
/**
647-
* line_status() - Read the status of the bus lines.
651+
* usb_gpib_line_status() - Read the status of the bus lines.
648652
*
649653
* @board: the gpib_board data area for this gpib interface
650654
*
651655
* We can read all lines.
652656
*/
653-
654-
#define WQT wait_queue_entry_t
655-
#define WQH head
656-
#define WQE entry
657-
658657
static int usb_gpib_line_status(const struct gpib_board *board)
659658
{
660659
int buffer;

0 commit comments

Comments
 (0)