Skip to content

Commit f18d5cf

Browse files
ahunter6acmel
authored andcommitted
perf scripts python: exported-sql-viewer.py: Fix time chart call tree
Using Python version 3.8.2 and PySide2 version 5.14.0, time chart call tree would not expand the tree to the result. Fix by using setExpanded(). Example: $ perf record -e intel_pt//u uname Linux [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.034 MB perf.data ] $ perf script --itrace=bep -s ~/libexec/perf-core/scripts/python/export-to-sqlite.py perf.data.db branches calls 2020-06-26 15:32:14.928997 Creating database ... 2020-06-26 15:32:14.933971 Writing records... 2020-06-26 15:32:15.535251 Adding indexes 2020-06-26 15:32:15.542993 Dropping unused tables 2020-06-26 15:32:15.549716 Done $ python3 ~/libexec/perf-core/scripts/python/exported-sql-viewer.py perf.data.db Select: Charts -> Time chart by CPU Move mouse over middle of chart Right-click and select Show Call Tree Before: displays Call Tree but not expanded to selected time After: displays Call Tree expanded to selected time Fixes: e69d5df ("perf scripts python: exported-sql-viewer.py: Add ability for Call tree to open at a specified task and time") Signed-off-by: Adrian Hunter <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: [email protected] Link: http://lore.kernel.org/lkml/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
1 parent 031c8d5 commit f18d5cf

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

tools/perf/scripts/python/exported-sql-viewer.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1130,6 +1130,7 @@ def DisplayThreadAtTime(self, comm_id, thread_id, time):
11301130
child = self.model.index(row, 0, parent)
11311131
if child.internalPointer().dbid == dbid:
11321132
found = True
1133+
self.view.setExpanded(parent, True)
11331134
self.view.setCurrentIndex(child)
11341135
parent = child
11351136
break
@@ -1142,6 +1143,7 @@ def DisplayThreadAtTime(self, comm_id, thread_id, time):
11421143
return
11431144
last_child = None
11441145
for row in xrange(n):
1146+
self.view.setExpanded(parent, True)
11451147
child = self.model.index(row, 0, parent)
11461148
child_call_time = child.internalPointer().call_time
11471149
if child_call_time < time:
@@ -1154,9 +1156,11 @@ def DisplayThreadAtTime(self, comm_id, thread_id, time):
11541156
if not last_child:
11551157
if not found:
11561158
child = self.model.index(0, 0, parent)
1159+
self.view.setExpanded(parent, True)
11571160
self.view.setCurrentIndex(child)
11581161
return
11591162
found = True
1163+
self.view.setExpanded(parent, True)
11601164
self.view.setCurrentIndex(last_child)
11611165
parent = last_child
11621166

0 commit comments

Comments
 (0)