Skip to content

Commit f1e2404

Browse files
author
Mikulas Patocka
committed
dm: use generic functions instead of disable_discard and disable_write_zeroes
A small code cleanup: use blk_queue_disable_discard and blk_queue_disable_write_zeroes instead of disable_discard and disable_write_zeroes. Signed-off-by: Mikulas Patocka <[email protected]>
1 parent 33304b7 commit f1e2404

File tree

3 files changed

+4
-23
lines changed

3 files changed

+4
-23
lines changed

drivers/md/dm-core.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -163,9 +163,6 @@ struct mapped_device {
163163
#define DMF_POST_SUSPENDING 8
164164
#define DMF_EMULATE_ZONE_APPEND 9
165165

166-
void disable_discard(struct mapped_device *md);
167-
void disable_write_zeroes(struct mapped_device *md);
168-
169166
static inline sector_t dm_get_size(struct mapped_device *md)
170167
{
171168
return get_capacity(md->disk);

drivers/md/dm-rq.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -217,10 +217,10 @@ static void dm_done(struct request *clone, blk_status_t error, bool mapped)
217217
if (unlikely(error == BLK_STS_TARGET)) {
218218
if (req_op(clone) == REQ_OP_DISCARD &&
219219
!clone->q->limits.max_discard_sectors)
220-
disable_discard(tio->md);
220+
blk_queue_disable_discard(tio->md->queue);
221221
else if (req_op(clone) == REQ_OP_WRITE_ZEROES &&
222222
!clone->q->limits.max_write_zeroes_sectors)
223-
disable_write_zeroes(tio->md);
223+
blk_queue_disable_write_zeroes(tio->md->queue);
224224
}
225225

226226
switch (r) {

drivers/md/dm.c

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1082,22 +1082,6 @@ static inline struct queue_limits *dm_get_queue_limits(struct mapped_device *md)
10821082
return &md->queue->limits;
10831083
}
10841084

1085-
void disable_discard(struct mapped_device *md)
1086-
{
1087-
struct queue_limits *limits = dm_get_queue_limits(md);
1088-
1089-
/* device doesn't really support DISCARD, disable it */
1090-
limits->max_hw_discard_sectors = 0;
1091-
}
1092-
1093-
void disable_write_zeroes(struct mapped_device *md)
1094-
{
1095-
struct queue_limits *limits = dm_get_queue_limits(md);
1096-
1097-
/* device doesn't really support WRITE ZEROES, disable it */
1098-
limits->max_write_zeroes_sectors = 0;
1099-
}
1100-
11011085
static bool swap_bios_limit(struct dm_target *ti, struct bio *bio)
11021086
{
11031087
return unlikely((bio->bi_opf & REQ_SWAP) != 0) && unlikely(ti->limit_swap_bios);
@@ -1115,10 +1099,10 @@ static void clone_endio(struct bio *bio)
11151099
if (unlikely(error == BLK_STS_TARGET)) {
11161100
if (bio_op(bio) == REQ_OP_DISCARD &&
11171101
!bdev_max_discard_sectors(bio->bi_bdev))
1118-
disable_discard(md);
1102+
blk_queue_disable_discard(md->queue);
11191103
else if (bio_op(bio) == REQ_OP_WRITE_ZEROES &&
11201104
!bdev_write_zeroes_sectors(bio->bi_bdev))
1121-
disable_write_zeroes(md);
1105+
blk_queue_disable_write_zeroes(md->queue);
11221106
}
11231107

11241108
if (static_branch_unlikely(&zoned_enabled) &&

0 commit comments

Comments
 (0)