Skip to content

Commit f21453b

Browse files
committed
tools/testing/nvdimm: Fix missing 'fallthrough' warning
Use "fallthrough;" to address: tools/testing/nvdimm/test/nfit.c: In function ‘nd_intel_test_finish_query’: tools/testing/nvdimm/test/nfit.c:436:37: warning: this statement may fall through [-Wimplicit-fallthrough=] 436 | fw->missed_activate = false; | ~~~~~~~~~~~~~~~~~~~~^~~~~~~ tools/testing/nvdimm/test/nfit.c:438:9: note: here 438 | case FW_STATE_UPDATED: | ^~~~ Reviewed-by: Jeff Moyer <[email protected]> Link: https://lore.kernel.org/r/162767522046.3313209.14767278726893995797.stgit@dwillia2-desk3.amr.corp.intel.com Signed-off-by: Dan Williams <[email protected]>
1 parent d9cee9f commit f21453b

File tree

1 file changed

+1
-1
lines changed
  • tools/testing/nvdimm/test

1 file changed

+1
-1
lines changed

tools/testing/nvdimm/test/nfit.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,7 @@ static int nd_intel_test_finish_query(struct nfit_test *t,
434434
dev_dbg(dev, "%s: transition out verify\n", __func__);
435435
fw->state = FW_STATE_UPDATED;
436436
fw->missed_activate = false;
437-
/* fall through */
437+
fallthrough;
438438
case FW_STATE_UPDATED:
439439
nd_cmd->status = 0;
440440
/* bogus test version */

0 commit comments

Comments
 (0)