Skip to content

Commit f248ff1

Browse files
Desnes Nunesgregkh
authored andcommitted
misc: rtsx: Cleanup on DRV_NAME cardreader variables
The rtsx_pci_ms memstick driver has been dropped, thus there is no more need for DRV_NAME_RTSX_PCI_MS variable. Additionally, this also stand- arizes DRV_NAME variables on alcor_pci and rtsx_usb drivers. Fixes: d0f4592 ("memstick: rtsx_pci_ms: Remove Realtek PCI memstick driver") Signed-off-by: Desnes Nunes <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent feb776a commit f248ff1

File tree

5 files changed

+8
-6
lines changed

5 files changed

+8
-6
lines changed

drivers/misc/cardreader/alcor_pci.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717

1818
#include <linux/alcor_pci.h>
1919

20-
#define DRV_NAME_ALCOR_PCI "alcor_pci"
21-
2220
static DEFINE_IDA(alcor_pci_idr);
2321

2422
static struct mfd_cell alcor_pci_cells[] = {

drivers/misc/cardreader/rtsx_usb.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ MODULE_PARM_DESC(polling_pipe, "polling pipe (0: ctl, 1: bulk)");
2020

2121
static const struct mfd_cell rtsx_usb_cells[] = {
2222
[RTSX_USB_SD_CARD] = {
23-
.name = "rtsx_usb_sdmmc",
23+
.name = DRV_NAME_RTSX_USB_SDMMC,
2424
.pdata_size = 0,
2525
},
2626
[RTSX_USB_MS_CARD] = {
27-
.name = "rtsx_usb_ms",
27+
.name = DRV_NAME_RTSX_USB_MS,
2828
.pdata_size = 0,
2929
},
3030
};
@@ -780,7 +780,7 @@ static const struct usb_device_id rtsx_usb_usb_ids[] = {
780780
MODULE_DEVICE_TABLE(usb, rtsx_usb_usb_ids);
781781

782782
static struct usb_driver rtsx_usb_driver = {
783-
.name = "rtsx_usb",
783+
.name = DRV_NAME_RTSX_USB,
784784
.probe = rtsx_usb_probe,
785785
.disconnect = rtsx_usb_disconnect,
786786
.suspend = rtsx_usb_suspend,

include/linux/alcor_pci.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#define ALCOR_SD_CARD 0
1212
#define ALCOR_MS_CARD 1
1313

14+
#define DRV_NAME_ALCOR_PCI "alcor_pci"
1415
#define DRV_NAME_ALCOR_PCI_SDMMC "alcor_sdmmc"
1516
#define DRV_NAME_ALCOR_PCI_MS "alcor_ms"
1617

include/linux/rtsx_common.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212

1313
#define DRV_NAME_RTSX_PCI "rtsx_pci"
1414
#define DRV_NAME_RTSX_PCI_SDMMC "rtsx_pci_sdmmc"
15-
#define DRV_NAME_RTSX_PCI_MS "rtsx_pci_ms"
1615

1716
#define RTSX_REG_PAIR(addr, val) (((u32)(addr) << 16) | (u8)(val))
1817

include/linux/rtsx_usb.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@
1212

1313
#include <linux/usb.h>
1414

15+
#define DRV_NAME_RTSX_USB "rtsx_usb"
16+
#define DRV_NAME_RTSX_USB_SDMMC "rtsx_usb_sdmmc"
17+
#define DRV_NAME_RTSX_USB_MS "rtsx_usb_ms"
18+
1519
/* related module names */
1620
#define RTSX_USB_SD_CARD 0
1721
#define RTSX_USB_MS_CARD 1

0 commit comments

Comments
 (0)