Skip to content

Commit f25f17d

Browse files
committed
ALSA: seq: ump: Fix conversion from MIDI2 to MIDI1 UMP messages
The conversion from MIDI2 to MIDI1 UMP messages had a leftover artifact (superfluous bit shift), and this resulted in the bogus type check, leading to empty outputs. Let's fix it. Fixes: e9e0281 ("ALSA: seq: Automatic conversion of UMP events") Cc: <[email protected]> Link: alsa-project/alsa-utils#262 Message-ID: <[email protected]> Signed-off-by: Takashi Iwai <[email protected]>
1 parent 7ee5faa commit f25f17d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sound/core/seq/seq_ump_convert.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,7 @@ static int cvt_ump_midi2_to_midi1(struct snd_seq_client *dest,
428428
midi1->note.group = midi2->note.group;
429429
midi1->note.status = midi2->note.status;
430430
midi1->note.channel = midi2->note.channel;
431-
switch (midi2->note.status << 4) {
431+
switch (midi2->note.status) {
432432
case UMP_MSG_STATUS_NOTE_ON:
433433
case UMP_MSG_STATUS_NOTE_OFF:
434434
midi1->note.note = midi2->note.note;

0 commit comments

Comments
 (0)