Skip to content

Commit f29536b

Browse files
rddunlapIngo Molnar
authored andcommitted
tick/sched: Fix various kernel-doc warnings
Fix a slew of kernel-doc warnings in tick-sched.c: tick-sched.c:650: warning: Function parameter or struct member 'now' not described in 'tick_nohz_update_jiffies' tick-sched.c:741: warning: No description found for return value of 'get_cpu_idle_time_us' tick-sched.c:767: warning: No description found for return value of 'get_cpu_iowait_time_us' tick-sched.c:1210: warning: No description found for return value of 'tick_nohz_idle_got_tick' tick-sched.c:1228: warning: No description found for return value of 'tick_nohz_get_next_hrtimer' tick-sched.c:1243: warning: No description found for return value of 'tick_nohz_get_sleep_length' tick-sched.c:1282: warning: Function parameter or struct member 'cpu' not described in 'tick_nohz_get_idle_calls_cpu' tick-sched.c:1282: warning: No description found for return value of 'tick_nohz_get_idle_calls_cpu' tick-sched.c:1294: warning: No description found for return value of 'tick_nohz_get_idle_calls' tick-sched.c:1577: warning: Function parameter or struct member 'hrtimer' not described in 'tick_setup_sched_timer' tick-sched.c:1577: warning: Excess function parameter 'mode' description in 'tick_setup_sched_timer' Signed-off-by: Randy Dunlap <[email protected]> Signed-off-by: Ingo Molnar <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent b87752e commit f29536b

File tree

1 file changed

+15
-3
lines changed

1 file changed

+15
-3
lines changed

kernel/time/tick-sched.c

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -697,6 +697,7 @@ bool tick_nohz_tick_stopped_cpu(int cpu)
697697

698698
/**
699699
* tick_nohz_update_jiffies - update jiffies when idle was interrupted
700+
* @now: current ktime_t
700701
*
701702
* Called from interrupt entry when the CPU was idle
702703
*
@@ -794,7 +795,7 @@ static u64 get_cpu_sleep_time_us(struct tick_sched *ts, ktime_t *sleeptime,
794795
* This time is measured via accounting rather than sampling,
795796
* and is as accurate as ktime_get() is.
796797
*
797-
* This function returns -1 if NOHZ is not enabled.
798+
* Return: -1 if NOHZ is not enabled, else total idle time of the @cpu
798799
*/
799800
u64 get_cpu_idle_time_us(int cpu, u64 *last_update_time)
800801
{
@@ -820,7 +821,7 @@ EXPORT_SYMBOL_GPL(get_cpu_idle_time_us);
820821
* This time is measured via accounting rather than sampling,
821822
* and is as accurate as ktime_get() is.
822823
*
823-
* This function returns -1 if NOHZ is not enabled.
824+
* Return: -1 if NOHZ is not enabled, else total iowait time of @cpu
824825
*/
825826
u64 get_cpu_iowait_time_us(int cpu, u64 *last_update_time)
826827
{
@@ -1287,6 +1288,8 @@ void tick_nohz_irq_exit(void)
12871288

12881289
/**
12891290
* tick_nohz_idle_got_tick - Check whether or not the tick handler has run
1291+
*
1292+
* Return: %true if the tick handler has run, otherwise %false
12901293
*/
12911294
bool tick_nohz_idle_got_tick(void)
12921295
{
@@ -1305,6 +1308,8 @@ bool tick_nohz_idle_got_tick(void)
13051308
* stopped, it returns the next hrtimer.
13061309
*
13071310
* Called from power state control code with interrupts disabled
1311+
*
1312+
* Return: the next expiration time
13081313
*/
13091314
ktime_t tick_nohz_get_next_hrtimer(void)
13101315
{
@@ -1320,6 +1325,8 @@ ktime_t tick_nohz_get_next_hrtimer(void)
13201325
* The return value of this function and/or the value returned by it through the
13211326
* @delta_next pointer can be negative which must be taken into account by its
13221327
* callers.
1328+
*
1329+
* Return: the expected length of the current sleep
13231330
*/
13241331
ktime_t tick_nohz_get_sleep_length(ktime_t *delta_next)
13251332
{
@@ -1357,8 +1364,11 @@ ktime_t tick_nohz_get_sleep_length(ktime_t *delta_next)
13571364
/**
13581365
* tick_nohz_get_idle_calls_cpu - return the current idle calls counter value
13591366
* for a particular CPU.
1367+
* @cpu: target CPU number
13601368
*
13611369
* Called from the schedutil frequency scaling governor in scheduler context.
1370+
*
1371+
* Return: the current idle calls counter value for @cpu
13621372
*/
13631373
unsigned long tick_nohz_get_idle_calls_cpu(int cpu)
13641374
{
@@ -1371,6 +1381,8 @@ unsigned long tick_nohz_get_idle_calls_cpu(int cpu)
13711381
* tick_nohz_get_idle_calls - return the current idle calls counter value
13721382
*
13731383
* Called from the schedutil frequency scaling governor in scheduler context.
1384+
*
1385+
* Return: the current idle calls counter value for the current CPU
13741386
*/
13751387
unsigned long tick_nohz_get_idle_calls(void)
13761388
{
@@ -1559,7 +1571,7 @@ early_param("skew_tick", skew_tick);
15591571

15601572
/**
15611573
* tick_setup_sched_timer - setup the tick emulation timer
1562-
* @mode: tick_nohz_mode to setup for
1574+
* @hrtimer: whether to use the hrtimer or not
15631575
*/
15641576
void tick_setup_sched_timer(bool hrtimer)
15651577
{

0 commit comments

Comments
 (0)