Skip to content

Commit f2dbca1

Browse files
Andy Yanvinodkoul
authored andcommitted
phy: phy-rockchip-samsung-hdptx: Don't request RST_PHY/RST_ROPLL/RST_LCPLL
RST_PHY/RST_ROPLL/RST_LCPLL are used for debug only on rk3588, and they are not exported on rk3576, no need to request it in driver. Signed-off-by: Andy Yan <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent c9be539 commit f2dbca1

File tree

1 file changed

+1
-16
lines changed

1 file changed

+1
-16
lines changed

drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -256,13 +256,10 @@ struct ropll_config {
256256
};
257257

258258
enum rk_hdptx_reset {
259-
RST_PHY = 0,
260-
RST_APB,
259+
RST_APB = 0,
261260
RST_INIT,
262261
RST_CMN,
263262
RST_LANE,
264-
RST_ROPLL,
265-
RST_LCPLL,
266263
RST_MAX
267264
};
268265

@@ -665,11 +662,6 @@ static void rk_hdptx_phy_disable(struct rk_hdptx_phy *hdptx)
665662
{
666663
u32 val;
667664

668-
/* reset phy and apb, or phy locked flag may keep 1 */
669-
reset_control_assert(hdptx->rsts[RST_PHY].rstc);
670-
usleep_range(20, 30);
671-
reset_control_deassert(hdptx->rsts[RST_PHY].rstc);
672-
673665
reset_control_assert(hdptx->rsts[RST_APB].rstc);
674666
usleep_range(20, 30);
675667
reset_control_deassert(hdptx->rsts[RST_APB].rstc);
@@ -792,10 +784,6 @@ static int rk_hdptx_ropll_tmds_cmn_config(struct rk_hdptx_phy *hdptx,
792784

793785
rk_hdptx_pre_power_up(hdptx);
794786

795-
reset_control_assert(hdptx->rsts[RST_ROPLL].rstc);
796-
usleep_range(20, 30);
797-
reset_control_deassert(hdptx->rsts[RST_ROPLL].rstc);
798-
799787
rk_hdptx_multi_reg_write(hdptx, rk_hdtpx_common_cmn_init_seq);
800788
rk_hdptx_multi_reg_write(hdptx, rk_hdtpx_tmds_cmn_init_seq);
801789

@@ -1098,13 +1086,10 @@ static int rk_hdptx_phy_probe(struct platform_device *pdev)
10981086
return dev_err_probe(dev, PTR_ERR(hdptx->regmap),
10991087
"Failed to init regmap\n");
11001088

1101-
hdptx->rsts[RST_PHY].id = "phy";
11021089
hdptx->rsts[RST_APB].id = "apb";
11031090
hdptx->rsts[RST_INIT].id = "init";
11041091
hdptx->rsts[RST_CMN].id = "cmn";
11051092
hdptx->rsts[RST_LANE].id = "lane";
1106-
hdptx->rsts[RST_ROPLL].id = "ropll";
1107-
hdptx->rsts[RST_LCPLL].id = "lcpll";
11081093

11091094
ret = devm_reset_control_bulk_get_exclusive(dev, RST_MAX, hdptx->rsts);
11101095
if (ret)

0 commit comments

Comments
 (0)