Skip to content

Commit f2dced9

Browse files
Dan Carpentermartinkpetersen
authored andcommitted
scsi: ufs: Uninitialized variable in ufshcd_devfreq_target()
There is one goto where "sched_clk_scaling_suspend_work" is true but "scale_up" is uninitialized. It leads to a Smatch uninitialized variable warning: drivers/ufs/core/ufshcd.c:1589 ufshcd_devfreq_target() error: uninitialized symbol 'scale_up'. Fixes: 1d96973 ("scsi: ufs: core: Only suspend clock scaling if scaling down") Signed-off-by: Dan Carpenter <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Peter Wang <[email protected]> Reviewed-by: Bart Van Assche <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent de95909 commit f2dced9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/ufs/core/ufshcd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1469,7 +1469,7 @@ static int ufshcd_devfreq_target(struct device *dev,
14691469
int ret = 0;
14701470
struct ufs_hba *hba = dev_get_drvdata(dev);
14711471
ktime_t start;
1472-
bool scale_up, sched_clk_scaling_suspend_work = false;
1472+
bool scale_up = false, sched_clk_scaling_suspend_work = false;
14731473
struct list_head *clk_list = &hba->clk_list_head;
14741474
struct ufs_clk_info *clki;
14751475
unsigned long irq_flags;

0 commit comments

Comments
 (0)