Skip to content

Commit f2e9d08

Browse files
oleremdavem330
authored andcommitted
net: phy: micrel: correct KSZ9131RNX EEE capabilities and advertisement
The KSZ9131RNX incorrectly shows EEE capabilities in its registers. Although the "EEE control and capability 1" (Register 3.20) is set to 0, indicating no EEE support, the "EEE advertisement 1" (Register 7.60) is set to 0x6, advertising EEE support for 1000BaseT/Full and 100BaseT/Full. This inconsistency causes PHYlib to assume there is no EEE support, preventing control over EEE advertisement, which is enabled by default. This patch resolves the issue by utilizing the ksz9477_get_features() function to correctly set the EEE capabilities for the KSZ9131RNX. This adjustment allows proper control over EEE advertisement and ensures accurate representation of the device's capabilities. Fixes: 8b68710 ("net: phy: start using genphy_c45_ethtool_get/set_eee()") Reported-by: Marek Vasut <[email protected]> Tested-by: Marek Vasut <[email protected]> Signed-off-by: Oleksij Rempel <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent b465518 commit f2e9d08

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/net/phy/micrel.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4151,6 +4151,7 @@ static struct phy_driver ksphy_driver[] = {
41514151
.resume = kszphy_resume,
41524152
.cable_test_start = ksz9x31_cable_test_start,
41534153
.cable_test_get_status = ksz9x31_cable_test_get_status,
4154+
.get_features = ksz9477_get_features,
41544155
}, {
41554156
.phy_id = PHY_ID_KSZ8873MLL,
41564157
.phy_id_mask = MICREL_PHY_ID_MASK,

0 commit comments

Comments
 (0)