Skip to content

Commit f2fb029

Browse files
committed
media: atomisp: improve IRQ handling debug messages
When an IRQ is not handled, it is nice to know what's the reason. Signed-off-by: Mauro Carvalho Chehab <[email protected]>
1 parent 495eef1 commit f2fb029

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

drivers/staging/media/atomisp/pci/atomisp_cmd.c

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -566,7 +566,7 @@ irqreturn_t atomisp_isr(int irq, void *dev)
566566

567567
if (irq_infos & IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF) {
568568
dev_dbg_ratelimited(isp->dev,
569-
"irq:0x%x (IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF)\n",
569+
"irq:0x%x (SOF)\n",
570570
irq_infos);
571571
irq_infos &= ~IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF;
572572
}
@@ -591,14 +591,14 @@ irqreturn_t atomisp_isr(int irq, void *dev)
591591
/* EOF Event does not have the css_pipe returned */
592592
asd = __get_asd_from_port(isp, eof_event.event.port);
593593
if (!asd) {
594-
dev_err(isp->dev, "%s:no subdev.event:%d",
594+
dev_err(isp->dev, "%s: ISYS event, but no subdev.event:%d",
595595
__func__, eof_event.event.type);
596596
continue;
597597
}
598598

599599
atomisp_eof_event(asd, eof_event.event.exp_id);
600600
dev_dbg_ratelimited(isp->dev,
601-
"%s EOF exp_id %d, asd %d\n",
601+
"%s ISYS event: EOF exp_id %d, asd %d\n",
602602
__func__, eof_event.event.exp_id,
603603
asd->index);
604604
}
@@ -610,15 +610,16 @@ irqreturn_t atomisp_isr(int irq, void *dev)
610610

611611
spin_unlock_irqrestore(&isp->lock, flags);
612612

613-
dev_dbg_ratelimited(isp->dev, "irq:0x%x\n", irq_infos);
613+
dev_dbg_ratelimited(isp->dev, "irq:0x%x (unhandled)\n", irq_infos);
614614

615615
return IRQ_WAKE_THREAD;
616616

617617
out_nowake:
618618
spin_unlock_irqrestore(&isp->lock, flags);
619619

620620
if (irq_infos)
621-
dev_dbg_ratelimited(isp->dev, "irq:0x%x\n", irq_infos);
621+
dev_dbg_ratelimited(isp->dev, "irq:0x%x (ignored, as not streaming anymore)\n",
622+
irq_infos);
622623

623624
return IRQ_HANDLED;
624625
}

0 commit comments

Comments
 (0)