reset: brcmstb-rescal: fix incorrect polarity of status bit

jim2101024 · pH5 · commit f33eb7f29c16 · 2021-10-05T10:48:56.000+02:00
The readl_poll_timeout() should complete when the status bit is a 1, not 0. Fixes: 4cf176e ("reset: Add Broadcom STB RESCAL reset controller") Signed-off-by: Jim Quinlan <jim2101024@gmail.com> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Link: https://lore.kernel.org/r/20210914221122.62315-1-f.fainelli@gmail.com Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
diff --git a/drivers/reset/reset-brcmstb-rescal.c b/drivers/reset/reset-brcmstb-rescal.c
@@ -38,7 +38,7 @@ static int brcm_rescal_reset_set(struct reset_controller_dev *rcdev,
 	}
 
 	ret = readl_poll_timeout(base + BRCM_RESCAL_STATUS, reg,
-				 !(reg & BRCM_RESCAL_STATUS_BIT), 100, 1000);
+				 (reg & BRCM_RESCAL_STATUS_BIT), 100, 1000);
 	if (ret) {
 		dev_err(data->dev, "time out on SATA/PCIe rescal\n");
 		return ret;

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ static int brcm_rescal_reset_set(struct reset_controller_dev *rcdev,`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`ret = readl_poll_timeout(base + BRCM_RESCAL_STATUS, reg,`
`41`		`- !(reg & BRCM_RESCAL_STATUS_BIT), 100, 1000);`
	`41`	`+ (reg & BRCM_RESCAL_STATUS_BIT), 100, 1000);`
`42`	`42`	`if (ret) {`
`43`	`43`	`dev_err(data->dev, "time out on SATA/PCIe rescal\n");`
`44`	`44`	`return ret;`