Skip to content

Commit f3600c8

Browse files
minakuba-moo
authored andcommitted
netmem: prevent TX of unreadable skbs
Currently on stable trees we have support for netmem/devmem RX but not TX. It is not safe to forward/redirect an RX unreadable netmem packet into the device's TX path, as the device may call dma-mapping APIs on dma addrs that should not be passed to it. Fix this by preventing the xmit of unreadable skbs. Tested by configuring tc redirect: sudo tc qdisc add dev eth1 ingress sudo tc filter add dev eth1 ingress protocol ip prio 1 flower ip_proto \ tcp src_ip 192.168.1.12 action mirred egress redirect dev eth1 Before, I see unreadable skbs in the driver's TX path passed to dma mapping APIs. After, I don't see unreadable skbs in the driver's TX path passed to dma mapping APIs. Fixes: 65249fe ("net: add support for skbs with unreadable frags") Suggested-by: Jakub Kicinski <[email protected]> Cc: [email protected] Signed-off-by: Mina Almasry <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 8ef0f2c commit f3600c8

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

net/core/dev.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3872,6 +3872,9 @@ static struct sk_buff *validate_xmit_skb(struct sk_buff *skb, struct net_device
38723872
{
38733873
netdev_features_t features;
38743874

3875+
if (!skb_frags_readable(skb))
3876+
goto out_kfree_skb;
3877+
38753878
features = netif_skb_features(skb);
38763879
skb = validate_xmit_vlan(skb, features);
38773880
if (unlikely(!skb))

0 commit comments

Comments
 (0)