Skip to content

Commit f373ebe

Browse files
jnar17johnharr-intel
authored andcommitted
drm/i915/guc: Update guc_err message to show outstanding g2h responses
Updating the guc_error message to show how many g2h responses are still outstanding, in order to help with future debugging. Signed-off-by: Jesus Narvaez <[email protected]> Cc: Daniele Ceraolo Spurio <[email protected]> Cc: John Harrison <[email protected]> Reviewed-by: Jonathan Cavitt <[email protected]> Signed-off-by: John Harrison <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 7ed047d commit f373ebe

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2046,6 +2046,8 @@ void intel_guc_submission_cancel_requests(struct intel_guc *guc)
20462046

20472047
void intel_guc_submission_reset_finish(struct intel_guc *guc)
20482048
{
2049+
int outstanding;
2050+
20492051
/* Reset called during driver load or during wedge? */
20502052
if (unlikely(!guc_submission_initialized(guc) ||
20512053
!intel_guc_is_fw_running(guc) ||
@@ -2059,8 +2061,10 @@ void intel_guc_submission_reset_finish(struct intel_guc *guc)
20592061
* see in CI if this happens frequently / a precursor to taking down the
20602062
* machine.
20612063
*/
2062-
if (atomic_read(&guc->outstanding_submission_g2h))
2063-
guc_err(guc, "Unexpected outstanding GuC to Host in reset finish\n");
2064+
outstanding = atomic_read(&guc->outstanding_submission_g2h);
2065+
if (outstanding)
2066+
guc_err(guc, "Unexpected outstanding GuC to Host response(s) in reset finish: %d\n",
2067+
outstanding);
20642068
atomic_set(&guc->outstanding_submission_g2h, 0);
20652069

20662070
intel_guc_global_policies_update(guc);

0 commit comments

Comments
 (0)