Skip to content

Commit f3a616e

Browse files
raagjadavUwe Kleine-König
authored andcommitted
pwm: lpss: drop redundant runtime PM handles
We no longer need empty runtime PM handles for PCI devices after commits [1] and [2]. Drop them and let PCI core take care of power state transitions. [1] c5eb119 ("PCI / PM: Allow runtime PM without callback functions") [2] fa885b0 ("PCI/PM: Allow runtime PM with no PM callbacks at all") Reviewed-by: Andy Shevchenko <[email protected]> Signed-off-by: Raag Jadav <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Uwe Kleine-König <[email protected]>
1 parent 07612a7 commit f3a616e

File tree

1 file changed

+0
-22
lines changed

1 file changed

+0
-22
lines changed

drivers/pwm/pwm-lpss-pci.c

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -46,25 +46,6 @@ static void pwm_lpss_remove_pci(struct pci_dev *pdev)
4646
pm_runtime_get_sync(&pdev->dev);
4747
}
4848

49-
static int pwm_lpss_runtime_suspend_pci(struct device *dev)
50-
{
51-
/*
52-
* The PCI core will handle transition to D3 automatically. We only
53-
* need to provide runtime PM hooks for that to happen.
54-
*/
55-
return 0;
56-
}
57-
58-
static int pwm_lpss_runtime_resume_pci(struct device *dev)
59-
{
60-
return 0;
61-
}
62-
63-
static DEFINE_RUNTIME_DEV_PM_OPS(pwm_lpss_pci_pm,
64-
pwm_lpss_runtime_suspend_pci,
65-
pwm_lpss_runtime_resume_pci,
66-
NULL);
67-
6849
static const struct pci_device_id pwm_lpss_pci_ids[] = {
6950
{ PCI_VDEVICE(INTEL, 0x0ac8), (unsigned long)&pwm_lpss_bxt_info},
7051
{ PCI_VDEVICE(INTEL, 0x0f08), (unsigned long)&pwm_lpss_byt_info},
@@ -84,9 +65,6 @@ static struct pci_driver pwm_lpss_driver_pci = {
8465
.id_table = pwm_lpss_pci_ids,
8566
.probe = pwm_lpss_probe_pci,
8667
.remove = pwm_lpss_remove_pci,
87-
.driver = {
88-
.pm = pm_ptr(&pwm_lpss_pci_pm),
89-
},
9068
};
9169
module_pci_driver(pwm_lpss_driver_pci);
9270

0 commit comments

Comments
 (0)