Skip to content

Commit f44fa35

Browse files
lategoodbyeffainelli
authored andcommitted
ARM: dts: bcm2711: Fix xHCI power-domain
During s2idle tests on the Raspberry CM4 the VPU firmware always crashes on xHCI power-domain resume: root@raspberrypi:/sys/power# echo freeze > state [ 70.724347] xhci_suspend finished [ 70.727730] xhci_plat_suspend finished [ 70.755624] bcm2835-power bcm2835-power: Power grafx off [ 70.761127] USB: Set power to 0 [ 74.653040] USB: Failed to set power to 1 (-110) This seems to be caused because of the mixed usage of raspberrypi-power and bcm2835-power at the same time. So avoid the usage of the VPU firmware power-domain driver, which prevents the VPU crash. Fixes: 522c35e ("ARM: dts: bcm2711: Add BCM2711 xHCI support") Link: raspberrypi/linux#6537 Signed-off-by: Stefan Wahren <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Florian Fainelli <[email protected]>
1 parent 2014c95 commit f44fa35

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

arch/arm/boot/dts/broadcom/bcm2711-rpi.dtsi

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// SPDX-License-Identifier: GPL-2.0
22
#include "bcm2835-rpi.dtsi"
33

4-
#include <dt-bindings/power/raspberrypi-power.h>
54
#include <dt-bindings/reset/raspberrypi,firmware-reset.h>
65

76
/ {
@@ -101,7 +100,3 @@
101100
&vchiq {
102101
interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
103102
};
104-
105-
&xhci {
106-
power-domains = <&power RPI_POWER_DOMAIN_USB>;
107-
};

arch/arm/boot/dts/broadcom/bcm2711.dtsi

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -610,6 +610,7 @@
610610
#address-cells = <1>;
611611
#size-cells = <0>;
612612
interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>;
613+
power-domains = <&pm BCM2835_POWER_DOMAIN_USB>;
613614
/* DWC2 and this IP block share the same USB PHY,
614615
* enabling both at the same time results in lockups.
615616
* So keep this node disabled and let the bootloader

0 commit comments

Comments
 (0)