Skip to content

Commit f477a53

Browse files
necipfazilRich Felker
authored andcommitted
sh: dma: fix kconfig dependency for G2_DMA
When G2_DMA is enabled and SH_DMA is disabled, it results in the following Kbuild warning: WARNING: unmet direct dependencies detected for SH_DMA_API Depends on [n]: SH_DMA [=n] Selected by [y]: - G2_DMA [=y] && SH_DREAMCAST [=y] The reason is that G2_DMA selects SH_DMA_API without depending on or selecting SH_DMA while SH_DMA_API depends on SH_DMA. When G2_DMA was first introduced with commit 40f49e7 ("sh: dma: Make G2 DMA configurable."), this wasn't an issue since SH_DMA_API didn't have such dependency, and this way was the only way to enable it since SH_DMA_API was non-visible. However, later SH_DMA_API was made visible and dependent on SH_DMA with commit d8902ad ("dmaengine: sh: Add Support SuperH DMA Engine driver"). Let G2_DMA depend on SH_DMA_API instead to avoid Kbuild issues. Fixes: d8902ad ("dmaengine: sh: Add Support SuperH DMA Engine driver") Signed-off-by: Necip Fazil Yildiran <[email protected]> Signed-off-by: Rich Felker <[email protected]>
1 parent 5c8fe58 commit f477a53

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

arch/sh/drivers/dma/Kconfig

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,7 @@ config PVR2_DMA
6363

6464
config G2_DMA
6565
tristate "G2 Bus DMA support"
66-
depends on SH_DREAMCAST
67-
select SH_DMA_API
66+
depends on SH_DREAMCAST && SH_DMA_API
6867
help
6968
This enables support for the DMA controller for the Dreamcast's
7069
G2 bus. Drivers that want this will generally enable this on

0 commit comments

Comments
 (0)