Skip to content

Commit f4b2ce4

Browse files
committed
pinctrl: renesas: rzv2m: Use devm_clk_get_enabled() helper
Simplify clock handling by using the devm_clk_get_enabled() helper, instead of open-coding the same operations. Move the clock pointer from the driver-private data to a local variable, as it is not needed outside the .probe() callback. Signed-off-by: Geert Uytterhoeven <[email protected]> Link: https://lore.kernel.org/r/cca0b1795fd0335401bdf2be393ab84445e04095.1688396836.git.geert+renesas@glider.be
1 parent bfc374a commit f4b2ce4

File tree

1 file changed

+5
-27
lines changed

1 file changed

+5
-27
lines changed

drivers/pinctrl/renesas/pinctrl-rzv2m.c

Lines changed: 5 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,6 @@ struct rzv2m_pinctrl {
118118
const struct rzv2m_pinctrl_data *data;
119119
void __iomem *base;
120120
struct device *dev;
121-
struct clk *clk;
122121

123122
struct gpio_chip gpio_chip;
124123
struct pinctrl_gpio_range gpio_range;
@@ -1039,14 +1038,10 @@ static int rzv2m_pinctrl_register(struct rzv2m_pinctrl *pctrl)
10391038
return 0;
10401039
}
10411040

1042-
static void rzv2m_pinctrl_clk_disable(void *data)
1043-
{
1044-
clk_disable_unprepare(data);
1045-
}
1046-
10471041
static int rzv2m_pinctrl_probe(struct platform_device *pdev)
10481042
{
10491043
struct rzv2m_pinctrl *pctrl;
1044+
struct clk *clk;
10501045
int ret;
10511046

10521047
pctrl = devm_kzalloc(&pdev->dev, sizeof(*pctrl), GFP_KERNEL);
@@ -1063,32 +1058,15 @@ static int rzv2m_pinctrl_probe(struct platform_device *pdev)
10631058
if (IS_ERR(pctrl->base))
10641059
return PTR_ERR(pctrl->base);
10651060

1066-
pctrl->clk = devm_clk_get(pctrl->dev, NULL);
1067-
if (IS_ERR(pctrl->clk)) {
1068-
ret = PTR_ERR(pctrl->clk);
1069-
dev_err(pctrl->dev, "failed to get GPIO clk : %i\n", ret);
1070-
return ret;
1071-
}
1061+
clk = devm_clk_get_enabled(pctrl->dev, NULL);
1062+
if (IS_ERR(clk))
1063+
return dev_err_probe(pctrl->dev, PTR_ERR(clk),
1064+
"failed to enable GPIO clk\n");
10721065

10731066
spin_lock_init(&pctrl->lock);
10741067

10751068
platform_set_drvdata(pdev, pctrl);
10761069

1077-
ret = clk_prepare_enable(pctrl->clk);
1078-
if (ret) {
1079-
dev_err(pctrl->dev, "failed to enable GPIO clk: %i\n", ret);
1080-
return ret;
1081-
}
1082-
1083-
ret = devm_add_action_or_reset(&pdev->dev, rzv2m_pinctrl_clk_disable,
1084-
pctrl->clk);
1085-
if (ret) {
1086-
dev_err(pctrl->dev,
1087-
"failed to register GPIO clk disable action, %i\n",
1088-
ret);
1089-
return ret;
1090-
}
1091-
10921070
ret = rzv2m_pinctrl_register(pctrl);
10931071
if (ret)
10941072
return ret;

0 commit comments

Comments
 (0)