Skip to content

Commit f4c16a7

Browse files
abelvesaandersson
authored andcommitted
clk: qcom: gcc-x1e80100: Fix USB 0 and 1 PHY GDSC pwrsts flags
Allowing these GDSCs to collapse makes the QMP combo PHYs lose their configuration on machine suspend. Currently, the QMP combo PHY driver doesn't reinitialise the HW on resume. Under such conditions, the USB SuperSpeed support is broken. To avoid this, mark the pwrsts flags with RET_ON. This is in line with USB 2 PHY GDSC config. Fixes: 161b7c4 ("clk: qcom: Add Global Clock controller (GCC) driver for X1E80100") Signed-off-by: Abel Vesa <[email protected]> Link: https://lore.kernel.org/r/20240801-x1e80100-clk-gcc-fix-usb-phy-gdscs-pwrsts-v1-1-8df016768a0f@linaro.org Signed-off-by: Bjorn Andersson <[email protected]>
1 parent f497313 commit f4c16a7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/clk/qcom/gcc-x1e80100.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6203,7 +6203,7 @@ static struct gdsc gcc_usb_0_phy_gdsc = {
62036203
.pd = {
62046204
.name = "gcc_usb_0_phy_gdsc",
62056205
},
6206-
.pwrsts = PWRSTS_OFF_ON,
6206+
.pwrsts = PWRSTS_RET_ON,
62076207
.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
62086208
};
62096209

@@ -6215,7 +6215,7 @@ static struct gdsc gcc_usb_1_phy_gdsc = {
62156215
.pd = {
62166216
.name = "gcc_usb_1_phy_gdsc",
62176217
},
6218-
.pwrsts = PWRSTS_OFF_ON,
6218+
.pwrsts = PWRSTS_RET_ON,
62196219
.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
62206220
};
62216221

0 commit comments

Comments
 (0)