Skip to content

Commit f577cd5

Browse files
Peter ZijlstraIngo Molnar
authored andcommitted
sched/topology: Rename 'DIE' domain to 'PKG'
While reworking the x86 topology code Thomas tripped over creating a 'DIE' domain for the package mask. :-) Since these names are CONFIG_SCHED_DEBUG=y only, rename them to make the name less ambiguous. [ Shrikanth Hegde: rename on s390 as well. ] [ Valentin Schneider: also rename it in the comments. ] [ mingo: port to recent kernels & find all remaining occurances. ] Reported-by: Thomas Gleixner <[email protected]> Signed-off-by: Peter Zijlstra (Intel) <[email protected]> Signed-off-by: Ingo Molnar <[email protected]> Acked-by: Valentin Schneider <[email protected]> Acked-by: Mel Gorman <[email protected]> Acked-by: Heiko Carstens <[email protected]> Acked-by: Gautham R. Shenoy <[email protected]> Acked-by: Vincent Guittot <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 3657680 commit f577cd5

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

arch/powerpc/kernel/smp.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1051,7 +1051,7 @@ static struct sched_domain_topology_level powerpc_topology[] = {
10511051
#endif
10521052
{ shared_cache_mask, powerpc_shared_cache_flags, SD_INIT_NAME(CACHE) },
10531053
{ cpu_mc_mask, SD_INIT_NAME(MC) },
1054-
{ cpu_cpu_mask, SD_INIT_NAME(DIE) },
1054+
{ cpu_cpu_mask, SD_INIT_NAME(PKG) },
10551055
{ NULL, },
10561056
};
10571057

@@ -1595,7 +1595,7 @@ static void add_cpu_to_masks(int cpu)
15951595
/* Skip all CPUs already part of current CPU core mask */
15961596
cpumask_andnot(mask, cpu_online_mask, cpu_core_mask(cpu));
15971597

1598-
/* If chip_id is -1; limit the cpu_core_mask to within DIE*/
1598+
/* If chip_id is -1; limit the cpu_core_mask to within PKG */
15991599
if (chip_id == -1)
16001600
cpumask_and(mask, mask, cpu_cpu_mask(cpu));
16011601

arch/s390/kernel/topology.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -522,7 +522,7 @@ static struct sched_domain_topology_level s390_topology[] = {
522522
{ cpu_coregroup_mask, cpu_core_flags, SD_INIT_NAME(MC) },
523523
{ cpu_book_mask, SD_INIT_NAME(BOOK) },
524524
{ cpu_drawer_mask, SD_INIT_NAME(DRAWER) },
525-
{ cpu_cpu_mask, SD_INIT_NAME(DIE) },
525+
{ cpu_cpu_mask, SD_INIT_NAME(PKG) },
526526
{ NULL, },
527527
};
528528

arch/x86/kernel/smpboot.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -641,13 +641,13 @@ static void __init build_sched_topology(void)
641641
};
642642
#endif
643643
/*
644-
* When there is NUMA topology inside the package skip the DIE domain
644+
* When there is NUMA topology inside the package skip the PKG domain
645645
* since the NUMA domains will auto-magically create the right spanning
646646
* domains based on the SLIT.
647647
*/
648648
if (!x86_has_numa_in_package) {
649649
x86_topology[i++] = (struct sched_domain_topology_level){
650-
cpu_cpu_mask, x86_die_flags, SD_INIT_NAME(DIE)
650+
cpu_cpu_mask, x86_die_flags, SD_INIT_NAME(PKG)
651651
};
652652
}
653653

kernel/sched/fair.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9555,7 +9555,7 @@ static bool sched_use_asym_prio(struct sched_domain *sd, int cpu)
95559555
* can only do it if @group is an SMT group and has exactly on busy CPU. Larger
95569556
* imbalances in the number of CPUS are dealt with in find_busiest_group().
95579557
*
9558-
* If we are balancing load within an SMT core, or at DIE domain level, always
9558+
* If we are balancing load within an SMT core, or at PKG domain level, always
95599559
* proceed.
95609560
*
95619561
* Return: true if @env::dst_cpu can do with asym_packing load balance. False

kernel/sched/topology.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1119,7 +1119,7 @@ build_overlap_sched_groups(struct sched_domain *sd, int cpu)
11191119
*
11201120
* - Simultaneous multithreading (SMT)
11211121
* - Multi-Core Cache (MC)
1122-
* - Package (DIE)
1122+
* - Package (PKG)
11231123
*
11241124
* Where the last one more or less denotes everything up to a NUMA node.
11251125
*
@@ -1141,13 +1141,13 @@ build_overlap_sched_groups(struct sched_domain *sd, int cpu)
11411141
*
11421142
* CPU 0 1 2 3 4 5 6 7
11431143
*
1144-
* DIE [ ]
1144+
* PKG [ ]
11451145
* MC [ ] [ ]
11461146
* SMT [ ] [ ] [ ] [ ]
11471147
*
11481148
* - or -
11491149
*
1150-
* DIE 0-7 0-7 0-7 0-7 0-7 0-7 0-7 0-7
1150+
* PKG 0-7 0-7 0-7 0-7 0-7 0-7 0-7 0-7
11511151
* MC 0-3 0-3 0-3 0-3 4-7 4-7 4-7 4-7
11521152
* SMT 0-1 0-1 2-3 2-3 4-5 4-5 6-7 6-7
11531153
*
@@ -1681,7 +1681,7 @@ static struct sched_domain_topology_level default_topology[] = {
16811681
#ifdef CONFIG_SCHED_MC
16821682
{ cpu_coregroup_mask, cpu_core_flags, SD_INIT_NAME(MC) },
16831683
#endif
1684-
{ cpu_cpu_mask, SD_INIT_NAME(DIE) },
1684+
{ cpu_cpu_mask, SD_INIT_NAME(PKG) },
16851685
{ NULL, },
16861686
};
16871687

0 commit comments

Comments
 (0)