Skip to content

Commit f5883ef

Browse files
author
Jiri Kosina
committed
Merge branch 'for-6.7/cp2112' into for-linus
- IRQ shutdown and workqueue initialization fixes for hid-cp2112 driver (Danny Kaehn)
2 parents 20cd569 + dc3115e commit f5883ef

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

drivers/hid/hid-cp2112.c

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1151,8 +1151,6 @@ static unsigned int cp2112_gpio_irq_startup(struct irq_data *d)
11511151
struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
11521152
struct cp2112_device *dev = gpiochip_get_data(gc);
11531153

1154-
INIT_DELAYED_WORK(&dev->gpio_poll_worker, cp2112_gpio_poll_callback);
1155-
11561154
if (!dev->gpio_poll) {
11571155
dev->gpio_poll = true;
11581156
schedule_delayed_work(&dev->gpio_poll_worker, 0);
@@ -1168,7 +1166,11 @@ static void cp2112_gpio_irq_shutdown(struct irq_data *d)
11681166
struct cp2112_device *dev = gpiochip_get_data(gc);
11691167

11701168
cp2112_gpio_irq_mask(d);
1171-
cancel_delayed_work_sync(&dev->gpio_poll_worker);
1169+
1170+
if (!dev->irq_mask) {
1171+
dev->gpio_poll = false;
1172+
cancel_delayed_work_sync(&dev->gpio_poll_worker);
1173+
}
11721174
}
11731175

11741176
static int cp2112_gpio_irq_type(struct irq_data *d, unsigned int type)
@@ -1307,6 +1309,8 @@ static int cp2112_probe(struct hid_device *hdev, const struct hid_device_id *id)
13071309
girq->handler = handle_simple_irq;
13081310
girq->threaded = true;
13091311

1312+
INIT_DELAYED_WORK(&dev->gpio_poll_worker, cp2112_gpio_poll_callback);
1313+
13101314
ret = gpiochip_add_data(&dev->gc, dev);
13111315
if (ret < 0) {
13121316
hid_err(hdev, "error registering gpio chip\n");

0 commit comments

Comments
 (0)