Skip to content

Commit f592797

Browse files
spbnickJiri Kosina
authored andcommitted
HID: uclogic: Support disabling pen usage
Restore the ability to disable pen usage in hid-uclogic to support e.g. keyboard interfaces which also have pen usages for some reason, but which we don't want to rewrite report descriptors for. Signed-off-by: Nikolai Kondrashov <[email protected]> Signed-off-by: José Expósito <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent d64a6e4 commit f592797

File tree

2 files changed

+26
-0
lines changed

2 files changed

+26
-0
lines changed

drivers/hid/hid-uclogic-core.c

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,24 @@ static __u8 *uclogic_report_fixup(struct hid_device *hdev, __u8 *rdesc,
8181
return rdesc;
8282
}
8383

84+
static int uclogic_input_mapping(struct hid_device *hdev,
85+
struct hid_input *hi,
86+
struct hid_field *field,
87+
struct hid_usage *usage,
88+
unsigned long **bit,
89+
int *max)
90+
{
91+
struct uclogic_drvdata *drvdata = hid_get_drvdata(hdev);
92+
struct uclogic_params *params = &drvdata->params;
93+
94+
/* Discard invalid pen usages */
95+
if (params->pen.usage_invalid && (field->application == HID_DG_PEN))
96+
return -1;
97+
98+
/* Let hid-core decide what to do */
99+
return 0;
100+
}
101+
84102
static int uclogic_input_configured(struct hid_device *hdev,
85103
struct hid_input *hi)
86104
{
@@ -515,6 +533,7 @@ static struct hid_driver uclogic_driver = {
515533
.remove = uclogic_remove,
516534
.report_fixup = uclogic_report_fixup,
517535
.raw_event = uclogic_raw_event,
536+
.input_mapping = uclogic_input_mapping,
518537
.input_configured = uclogic_input_configured,
519538
#ifdef CONFIG_PM
520539
.resume = uclogic_resume,

drivers/hid/hid-uclogic-params.h

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,11 @@ struct uclogic_params_pen_subreport {
6161
* Noop (preserving functionality) when filled with zeroes.
6262
*/
6363
struct uclogic_params_pen {
64+
/*
65+
* True if pen usage is invalid for this interface and should be
66+
* ignored, false otherwise.
67+
*/
68+
bool usage_invalid;
6469
/*
6570
* Pointer to report descriptor part describing the pen inputs.
6671
* Allocated with kmalloc. NULL if the part is not specified.
@@ -214,6 +219,7 @@ extern int uclogic_params_init(struct uclogic_params *params,
214219
".desc_ptr = %p\n" \
215220
".desc_size = %u\n" \
216221
".pen = {\n" \
222+
"\t.usage_invalid = %s\n" \
217223
"\t.desc_ptr = %p\n" \
218224
"\t.desc_size = %u\n" \
219225
"\t.id = %u\n" \
@@ -270,6 +276,7 @@ extern int uclogic_params_init(struct uclogic_params *params,
270276
((_params)->invalid ? "true" : "false"), \
271277
(_params)->desc_ptr, \
272278
(_params)->desc_size, \
279+
((_params)->pen.usage_invalid ? "true" : "false"), \
273280
(_params)->pen.desc_ptr, \
274281
(_params)->pen.desc_size, \
275282
(_params)->pen.id, \

0 commit comments

Comments
 (0)