Skip to content

Commit f5a88b0

Browse files
khfengtiwai
authored andcommitted
ALSA: hda/realtek: Enable mute LED on an HP system
The system in question uses ALC285, and it uses GPIO 0x04 to control its mute LED. The mic mute LED can be controlled by GPIO 0x01, however the system uses DMIC so we should use that to control mic mute LED. Signed-off-by: Kai-Heng Feng <[email protected]> Cc: <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent e9097e4 commit f5a88b0

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

sound/pci/hda/patch_realtek.c

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4008,6 +4008,12 @@ static void alc269_fixup_hp_gpio_led(struct hda_codec *codec,
40084008
alc_fixup_hp_gpio_led(codec, action, 0x08, 0x10);
40094009
}
40104010

4011+
static void alc285_fixup_hp_gpio_led(struct hda_codec *codec,
4012+
const struct hda_fixup *fix, int action)
4013+
{
4014+
alc_fixup_hp_gpio_led(codec, action, 0x04, 0x00);
4015+
}
4016+
40114017
static void alc286_fixup_hp_gpio_led(struct hda_codec *codec,
40124018
const struct hda_fixup *fix, int action)
40134019
{
@@ -5923,6 +5929,7 @@ enum {
59235929
ALC294_FIXUP_ASUS_DUAL_SPK,
59245930
ALC285_FIXUP_THINKPAD_HEADSET_JACK,
59255931
ALC294_FIXUP_ASUS_HPE,
5932+
ALC285_FIXUP_HP_GPIO_LED,
59265933
};
59275934

59285935
static const struct hda_fixup alc269_fixups[] = {
@@ -7061,6 +7068,10 @@ static const struct hda_fixup alc269_fixups[] = {
70617068
.chained = true,
70627069
.chain_id = ALC294_FIXUP_ASUS_HEADSET_MIC
70637070
},
7071+
[ALC285_FIXUP_HP_GPIO_LED] = {
7072+
.type = HDA_FIXUP_FUNC,
7073+
.v.func = alc285_fixup_hp_gpio_led,
7074+
},
70647075
};
70657076

70667077
static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -7208,6 +7219,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
72087219
SND_PCI_QUIRK(0x103c, 0x83b9, "HP Spectre x360", ALC269_FIXUP_HP_MUTE_LED_MIC3),
72097220
SND_PCI_QUIRK(0x103c, 0x8497, "HP Envy x360", ALC269_FIXUP_HP_MUTE_LED_MIC3),
72107221
SND_PCI_QUIRK(0x103c, 0x84e7, "HP Pavilion 15", ALC269_FIXUP_HP_MUTE_LED_MIC3),
7222+
SND_PCI_QUIRK(0x103c, 0x8736, "HP", ALC285_FIXUP_HP_GPIO_LED),
72117223
SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC),
72127224
SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300),
72137225
SND_PCI_QUIRK(0x1043, 0x106d, "Asus K53BE", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),

0 commit comments

Comments
 (0)