Skip to content

Commit f5ad594

Browse files
andy-shevlag-linaro
authored andcommitted
leds: gpio: Utilise PTR_ERR_OR_ZERO()
Avoid a boilerplate code by using PTR_ERR_OR_ZERO() in create_gpio_led(). Signed-off-by: Andy Shevchenko <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Lee Jones <[email protected]>
1 parent e80fc4b commit f5ad594

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

drivers/leds/leds-gpio.c

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -125,16 +125,13 @@ static int create_gpio_led(const struct gpio_led *template,
125125
return ret;
126126

127127
pinctrl = devm_pinctrl_get_select_default(led_dat->cdev.dev);
128-
if (IS_ERR(pinctrl)) {
129-
ret = PTR_ERR(pinctrl);
130-
if (ret != -ENODEV) {
131-
dev_warn(led_dat->cdev.dev,
132-
"Failed to select %pfw pinctrl: %d\n",
133-
fwnode, ret);
134-
} else {
135-
/* pinctrl-%d not present, not an error */
136-
ret = 0;
137-
}
128+
ret = PTR_ERR_OR_ZERO(pinctrl);
129+
/* pinctrl-%d not present, not an error */
130+
if (ret == -ENODEV)
131+
ret = 0;
132+
if (ret) {
133+
dev_warn(led_dat->cdev.dev, "Failed to select %pfw pinctrl: %d\n",
134+
fwnode, ret);
138135
}
139136

140137
return ret;

0 commit comments

Comments
 (0)