Skip to content

Commit f5fa54f

Browse files
Paul Hsiehalexdeucher
authored andcommitted
drm/amd/display: watermark latencies is not enough on DCN31
[Why] The original latencies were causing underflow in some modes. Resolution: 2880x1620@60p when HDR enable [How] 1. Replace with the up-to-date watermark values based on new measurments 2. Correct the ddr_wm_table name to DDR5 on DCN31 Tested-by: Daniel Wheeler <[email protected]> Reviewed-by: Aric Cyr <[email protected]> Acked-by: Stylon Wang <[email protected]> Signed-off-by: Paul Hsieh <[email protected]> Signed-off-by: Alex Deucher <[email protected]> Cc: [email protected]
1 parent 2d8ae25 commit f5fa54f

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -329,38 +329,38 @@ static struct clk_bw_params dcn31_bw_params = {
329329

330330
};
331331

332-
static struct wm_table ddr4_wm_table = {
332+
static struct wm_table ddr5_wm_table = {
333333
.entries = {
334334
{
335335
.wm_inst = WM_A,
336336
.wm_type = WM_TYPE_PSTATE_CHG,
337337
.pstate_latency_us = 11.72,
338-
.sr_exit_time_us = 6.09,
339-
.sr_enter_plus_exit_time_us = 7.14,
338+
.sr_exit_time_us = 9,
339+
.sr_enter_plus_exit_time_us = 11,
340340
.valid = true,
341341
},
342342
{
343343
.wm_inst = WM_B,
344344
.wm_type = WM_TYPE_PSTATE_CHG,
345345
.pstate_latency_us = 11.72,
346-
.sr_exit_time_us = 10.12,
347-
.sr_enter_plus_exit_time_us = 11.48,
346+
.sr_exit_time_us = 9,
347+
.sr_enter_plus_exit_time_us = 11,
348348
.valid = true,
349349
},
350350
{
351351
.wm_inst = WM_C,
352352
.wm_type = WM_TYPE_PSTATE_CHG,
353353
.pstate_latency_us = 11.72,
354-
.sr_exit_time_us = 10.12,
355-
.sr_enter_plus_exit_time_us = 11.48,
354+
.sr_exit_time_us = 9,
355+
.sr_enter_plus_exit_time_us = 11,
356356
.valid = true,
357357
},
358358
{
359359
.wm_inst = WM_D,
360360
.wm_type = WM_TYPE_PSTATE_CHG,
361361
.pstate_latency_us = 11.72,
362-
.sr_exit_time_us = 10.12,
363-
.sr_enter_plus_exit_time_us = 11.48,
362+
.sr_exit_time_us = 9,
363+
.sr_enter_plus_exit_time_us = 11,
364364
.valid = true,
365365
},
366366
}
@@ -687,7 +687,7 @@ void dcn31_clk_mgr_construct(
687687
if (ctx->dc_bios->integrated_info->memory_type == LpDdr5MemType) {
688688
dcn31_bw_params.wm_table = lpddr5_wm_table;
689689
} else {
690-
dcn31_bw_params.wm_table = ddr4_wm_table;
690+
dcn31_bw_params.wm_table = ddr5_wm_table;
691691
}
692692
/* Saved clocks configured at boot for debug purposes */
693693
dcn31_dump_clk_registers(&clk_mgr->base.base.boot_snapshot, &clk_mgr->base.base, &log_info);

0 commit comments

Comments
 (0)