Skip to content

Commit f61cf8d

Browse files
committed
Merge tag 'char-misc-5.5-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
Pull char/misc driver fixes from Greg KH: "Here are six small fixes for some reported char/misc driver issues: - fix build warnings with new 'awk' with the raid6 code - four interconnect driver bugfixes - binder fix for reported problem All of these except the binder fix have been in linux-next with no reported issues. The binder fix is "new" but Todd says it is good as he has tested it :)" * tag 'char-misc-5.5-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc: binder: fix incorrect calculation for num_valid interconnect: qcom: msm8974: Walk the list safely on node removal interconnect: qcom: qcs404: Walk the list safely on node removal interconnect: qcom: sdm845: Walk the list safely on node removal interconnect: qcom: Fix Kconfig indentation lib: raid6: fix awk build warnings
2 parents 894554c + 1698174 commit f61cf8d

File tree

6 files changed

+20
-20
lines changed

6 files changed

+20
-20
lines changed

drivers/android/binder.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3310,7 +3310,7 @@ static void binder_transaction(struct binder_proc *proc,
33103310
binder_size_t parent_offset;
33113311
struct binder_fd_array_object *fda =
33123312
to_binder_fd_array_object(hdr);
3313-
size_t num_valid = (buffer_offset - off_start_offset) *
3313+
size_t num_valid = (buffer_offset - off_start_offset) /
33143314
sizeof(binder_size_t);
33153315
struct binder_buffer_object *parent =
33163316
binder_validate_ptr(target_proc, t->buffer,
@@ -3384,7 +3384,7 @@ static void binder_transaction(struct binder_proc *proc,
33843384
t->buffer->user_data + sg_buf_offset;
33853385
sg_buf_offset += ALIGN(bp->length, sizeof(u64));
33863386

3387-
num_valid = (buffer_offset - off_start_offset) *
3387+
num_valid = (buffer_offset - off_start_offset) /
33883388
sizeof(binder_size_t);
33893389
ret = binder_fixup_parent(t, thread, bp,
33903390
off_start_offset,

drivers/interconnect/qcom/Kconfig

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@ config INTERCONNECT_QCOM
66
Support for Qualcomm's Network-on-Chip interconnect hardware.
77

88
config INTERCONNECT_QCOM_MSM8974
9-
tristate "Qualcomm MSM8974 interconnect driver"
10-
depends on INTERCONNECT_QCOM
11-
depends on QCOM_SMD_RPM
12-
select INTERCONNECT_QCOM_SMD_RPM
13-
help
14-
This is a driver for the Qualcomm Network-on-Chip on msm8974-based
15-
platforms.
9+
tristate "Qualcomm MSM8974 interconnect driver"
10+
depends on INTERCONNECT_QCOM
11+
depends on QCOM_SMD_RPM
12+
select INTERCONNECT_QCOM_SMD_RPM
13+
help
14+
This is a driver for the Qualcomm Network-on-Chip on msm8974-based
15+
platforms.
1616

1717
config INTERCONNECT_QCOM_QCS404
1818
tristate "Qualcomm QCS404 interconnect driver"

drivers/interconnect/qcom/msm8974.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -652,7 +652,7 @@ static int msm8974_icc_probe(struct platform_device *pdev)
652652
struct device *dev = &pdev->dev;
653653
struct icc_onecell_data *data;
654654
struct icc_provider *provider;
655-
struct icc_node *node;
655+
struct icc_node *node, *tmp;
656656
size_t num_nodes, i;
657657
int ret;
658658

@@ -732,7 +732,7 @@ static int msm8974_icc_probe(struct platform_device *pdev)
732732
return 0;
733733

734734
err_del_icc:
735-
list_for_each_entry(node, &provider->nodes, node_list) {
735+
list_for_each_entry_safe(node, tmp, &provider->nodes, node_list) {
736736
icc_node_del(node);
737737
icc_node_destroy(node->id);
738738
}
@@ -748,9 +748,9 @@ static int msm8974_icc_remove(struct platform_device *pdev)
748748
{
749749
struct msm8974_icc_provider *qp = platform_get_drvdata(pdev);
750750
struct icc_provider *provider = &qp->provider;
751-
struct icc_node *n;
751+
struct icc_node *n, *tmp;
752752

753-
list_for_each_entry(n, &provider->nodes, node_list) {
753+
list_for_each_entry_safe(n, tmp, &provider->nodes, node_list) {
754754
icc_node_del(n);
755755
icc_node_destroy(n->id);
756756
}

drivers/interconnect/qcom/qcs404.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@ static int qnoc_probe(struct platform_device *pdev)
414414
struct icc_provider *provider;
415415
struct qcom_icc_node **qnodes;
416416
struct qcom_icc_provider *qp;
417-
struct icc_node *node;
417+
struct icc_node *node, *tmp;
418418
size_t num_nodes, i;
419419
int ret;
420420

@@ -494,7 +494,7 @@ static int qnoc_probe(struct platform_device *pdev)
494494

495495
return 0;
496496
err:
497-
list_for_each_entry(node, &provider->nodes, node_list) {
497+
list_for_each_entry_safe(node, tmp, &provider->nodes, node_list) {
498498
icc_node_del(node);
499499
icc_node_destroy(node->id);
500500
}
@@ -508,9 +508,9 @@ static int qnoc_remove(struct platform_device *pdev)
508508
{
509509
struct qcom_icc_provider *qp = platform_get_drvdata(pdev);
510510
struct icc_provider *provider = &qp->provider;
511-
struct icc_node *n;
511+
struct icc_node *n, *tmp;
512512

513-
list_for_each_entry(n, &provider->nodes, node_list) {
513+
list_for_each_entry_safe(n, tmp, &provider->nodes, node_list) {
514514
icc_node_del(n);
515515
icc_node_destroy(n->id);
516516
}

drivers/interconnect/qcom/sdm845.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -868,9 +868,9 @@ static int qnoc_remove(struct platform_device *pdev)
868868
{
869869
struct qcom_icc_provider *qp = platform_get_drvdata(pdev);
870870
struct icc_provider *provider = &qp->provider;
871-
struct icc_node *n;
871+
struct icc_node *n, *tmp;
872872

873-
list_for_each_entry(n, &provider->nodes, node_list) {
873+
list_for_each_entry_safe(n, tmp, &provider->nodes, node_list) {
874874
icc_node_del(n);
875875
icc_node_destroy(n->id);
876876
}

lib/raid6/unroll.awk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ BEGIN {
1313
for (i = 0; i < rep; ++i) {
1414
tmp = $0
1515
gsub(/\$\$/, i, tmp)
16-
gsub(/\$\#/, n, tmp)
16+
gsub(/\$#/, n, tmp)
1717
gsub(/\$\*/, "$", tmp)
1818
print tmp
1919
}

0 commit comments

Comments
 (0)