Skip to content

Commit f62ec13

Browse files
committed
firewire: core: non-atomic memory allocation for isochronous event to user client
In the former commits, the callback of isochronous context runs on work process, thus no need to use atomic memory allocation. This commit replaces GFP_ATOMIC with GCP_KERNEL in the callback for user client. Tested-by: Edmund Raile <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Sakamoto <[email protected]>
1 parent 5390813 commit f62ec13

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/firewire/core-cdev.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -982,7 +982,7 @@ static void iso_callback(struct fw_iso_context *context, u32 cycle,
982982
struct client *client = data;
983983
struct iso_interrupt_event *e;
984984

985-
e = kmalloc(sizeof(*e) + header_length, GFP_ATOMIC);
985+
e = kmalloc(sizeof(*e) + header_length, GFP_KERNEL);
986986
if (e == NULL)
987987
return;
988988

@@ -1001,7 +1001,7 @@ static void iso_mc_callback(struct fw_iso_context *context,
10011001
struct client *client = data;
10021002
struct iso_interrupt_mc_event *e;
10031003

1004-
e = kmalloc(sizeof(*e), GFP_ATOMIC);
1004+
e = kmalloc(sizeof(*e), GFP_KERNEL);
10051005
if (e == NULL)
10061006
return;
10071007

0 commit comments

Comments
 (0)