Skip to content

Commit f685dd7

Browse files
paulmenzelhdeller
authored andcommitted
fbdev: matroxfb: G200eW: Increase max memory from 1 MB to 16 MB
Commit 62d89a7 ("video: fbdev: matroxfb: set maxvram of vbG200eW to the same as vbG200 to avoid black screen") accidently decreases the maximum memory size for the Matrox G200eW (102b:0532) from 8 MB to 1 MB by missing one zero. This caused the driver initialization to fail with the messages below, as the minimum required VRAM size is 2 MB: [ 9.436420] matroxfb: Matrox MGA-G200eW (PCI) detected [ 9.444502] matroxfb: cannot determine memory size [ 9.449316] matroxfb: probe of 0000:0a:03.0 failed with error -1 So, add the missing 0 to make it the intended 16 MB. Successfully tested on the Dell PowerEdge R910/0KYD3D, BIOS 2.10.0 08/29/2013, that the warning is gone. While at it, add a leading 0 to the maxdisplayable entry, so it’s aligned properly. The value could probably also be increased from 8 MB to 16 MB, as the G200 uses the same values, but I have not checked any datasheet. Note, matroxfb is obsolete and superseded by the maintained DRM driver mga200, which is used by default on most systems where both drivers are available. Therefore, on most systems it was only a cosmetic issue. Fixes: 62d89a7 ("video: fbdev: matroxfb: set maxvram of vbG200eW to the same as vbG200 to avoid black screen") Link: https://lore.kernel.org/linux-fbdev/[email protected]/T/#mb6953a9995ebd18acc8552f99d6db39787aec775 Cc: [email protected] Cc: Z. Liu <[email protected]> Cc: Rich Felker <[email protected]> Cc: [email protected] Signed-off-by: Paul Menzel <[email protected]> Signed-off-by: Helge Deller <[email protected]>
1 parent 6b90032 commit f685dd7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/video/fbdev/matrox/matroxfb_base.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1378,8 +1378,8 @@ static struct video_board vbG200 = {
13781378
.lowlevel = &matrox_G100
13791379
};
13801380
static struct video_board vbG200eW = {
1381-
.maxvram = 0x100000,
1382-
.maxdisplayable = 0x800000,
1381+
.maxvram = 0x1000000,
1382+
.maxdisplayable = 0x0800000,
13831383
.accelID = FB_ACCEL_MATROX_MGAG200,
13841384
.lowlevel = &matrox_G100
13851385
};

0 commit comments

Comments
 (0)