Skip to content

Commit f6a7d39

Browse files
committed
drm/i915: Suppress spurious underruns on gen2
Often we seem to detect an underrun right after modeset on gen2. It seems to be a spurious detection (potentially the pipe is still in a wonky state when we enable the planes). An extra vblank wait seems to cure it. Signed-off-by: Ville Syrjälä <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Reviewed-by: José Roberto de Souza <[email protected]>
1 parent 42ae1f8 commit f6a7d39

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/gpu/drm/i915/display/intel_display.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7526,6 +7526,10 @@ static void i9xx_crtc_enable(struct intel_atomic_state *state,
75267526
intel_crtc_vblank_on(new_crtc_state);
75277527

75287528
intel_encoders_enable(state, crtc);
7529+
7530+
/* prevents spurious underruns */
7531+
if (IS_GEN(dev_priv, 2))
7532+
intel_wait_for_vblank(dev_priv, pipe);
75297533
}
75307534

75317535
static void i9xx_pfit_disable(const struct intel_crtc_state *old_crtc_state)

0 commit comments

Comments
 (0)