Skip to content

Commit f6fd5d4

Browse files
claudiubeznealinusw
authored andcommitted
pinctrl: at91-pio4: check return value of devm_kasprintf()
devm_kasprintf() returns a pointer to dynamically allocated memory. Pointer could be NULL in case allocation fails. Check pointer validity. Identified with coccinelle (kmerr.cocci script). Fixes: 7761808 ("pinctrl: introduce driver for Atmel PIO4 controller") Depends-on: 1c4e5c4 ("pinctrl: at91: use devm_kasprintf() to avoid potential leaks") Depends-on: 5a8f9cf ("pinctrl: at91-pio4: use proper format specifier for unsigned int") Signed-off-by: Claudiu Beznea <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Linus Walleij <[email protected]>
1 parent 310cd4c commit f6fd5d4

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/pinctrl/pinctrl-at91-pio4.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1153,6 +1153,8 @@ static int atmel_pinctrl_probe(struct platform_device *pdev)
11531153
/* Pin naming convention: P(bank_name)(bank_pin_number). */
11541154
pin_desc[i].name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "P%c%u",
11551155
bank + 'A', line);
1156+
if (!pin_desc[i].name)
1157+
return -ENOMEM;
11561158

11571159
group->name = group_names[i] = pin_desc[i].name;
11581160
group->pin = pin_desc[i].number;

0 commit comments

Comments
 (0)