firmware: arm_scmi: Fix return error code in smc_send_message

sudeep-holla · sudeep-holla · commit f7199cf48902 · 2020-04-20T17:57:34.000+01:00
SMCCC can return NOT_SUPPORTED(-1). Map it to appropriate Linux error codes namely -EOPNOTSUPP. Link: https://lore.kernel.org/r/20200417103232.6896-1-sudeep.holla@arm.com Reported-and-Tested-by:: Etienne Carriere <etienne.carriere@linaro.org> Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org> Reviewed-by: Peng Fan <peng.fan@nxp.com> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
diff --git a/drivers/firmware/arm_scmi/smc.c b/drivers/firmware/arm_scmi/smc.c
@@ -114,7 +114,10 @@ static int smc_send_message(struct scmi_chan_info *cinfo,
 
 	mutex_unlock(&scmi_info->shmem_lock);
 
-	return res.a0;
+	/* Only SMCCC_RET_NOT_SUPPORTED is valid error code */
+	if (res.a0)
+		return -EOPNOTSUPP;
+	return 0;
 }
 
 static void smc_fetch_response(struct scmi_chan_info *cinfo,

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,10 @@ static int smc_send_message(struct scmi_chan_info *cinfo,`
`114`	`114`
`115`	`115`	`mutex_unlock(&scmi_info->shmem_lock);`
`116`	`116`
`117`		`- return res.a0;`
	`117`	`+ /* Only SMCCC_RET_NOT_SUPPORTED is valid error code */`
	`118`	`+ if (res.a0)`
	`119`	`+ return -EOPNOTSUPP;`
	`120`	`+ return 0;`
`118`	`121`	`}`
`119`	`122`
`120`	`123`	`static void smc_fetch_response(struct scmi_chan_info *cinfo,`